Bug 28175 - HTML 5 database and LocalStorage is not persistent on the Symbian port of QtWebKit
Summary: HTML 5 database and LocalStorage is not persistent on the Symbian port of QtW...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-11 06:21 PDT by Laszlo Gombos
Modified: 2009-08-12 09:42 PDT (History)
1 user (show)

See Also:


Attachments
proposed patch. (1.23 KB, patch)
2009-08-11 06:27 PDT, Laszlo Gombos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2009-08-11 06:21:18 PDT
The path separators in the path that is being passed to sqlite is not the native OS path; instead it is always the "/" - the Qt universal directory separator. Most OS (even Windows I think) understands the "/" separator - but not Symbian. The problem could be solved by calling QDir::toNativeSeparators() before the path is passed to the OS.

The problem and the possible solution was brought to my attention by David Leong.
Comment 1 Laszlo Gombos 2009-08-11 06:27:44 PDT
Created attachment 34553 [details]
proposed patch.

WebCore::pathByAppendingComponent() seems to be a good place to call QDir::toNativeSeparators before the path is passed to the OS. All the path construction to sqlite DBs are going trough this function.
Comment 2 Eric Seidel (no email) 2009-08-11 22:32:21 PDT
Comment on attachment 34553 [details]
proposed patch.

Seems OK.  I'm not sure this is the right place for this change.  But i'm not sure I have a better suggestion.
Comment 3 Eric Seidel (no email) 2009-08-12 09:42:05 PDT
Comment on attachment 34553 [details]
proposed patch.

Clearing flags on attachment: 34553

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/platform/qt/FileSystemQt.cpp
Committed r47114
	M	WebCore/ChangeLog
	M	WebCore/platform/qt/FileSystemQt.cpp
r47114 = 7f2ff9356922227e477417a6efb09c9d854e485e (trunk)
No changes between current HEAD and refs/remotes/trunk
Resetting to the latest refs/remotes/trunk
http://trac.webkit.org/changeset/47114
Comment 4 Eric Seidel (no email) 2009-08-12 09:42:08 PDT
All reviewed patches have been landed.  Closing bug.