Bug 28174 – Profile and Database views' status bar buttons are blank

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Mikhail Naganov]

This bug was introduced in r46979. Profile view buttons (those shown below a profile view) wasn't updated to use createStatusBarButton method. As a result, they are blank.

Trying to fix it naively, I've found that as profile view doesn't have a reference to a Profiles panel, it would need to access the createStatusBarButton function through WebInspector.panels.profiler, which isn't good. So I've decided to encapsulate glyph-based buttons into a new class. As an additional benifit, this allowed to encapsulate toggling and hiding functionality.

[Mikhail Naganov]

Created attachment 34552 [details]
Proposed change

[Timothy Hatcher]

Comment on attachment 34552 [details]
Proposed change

I like the new class, but it should go into it's own file and not part of Panel.js.

Also I think toggled would be a better name for the getter/setter than toggledOn.

[Mikhail Naganov]

Created attachment 34644 [details]
Updated patch---comments addressed

[Joseph Pecoraro]

Mikhail this is pretty awesome!

Heads up on a few other buttons.
  - delete button in DOMStorageItemsView.js.
  - delete button in CookieItemsView.js. (just added)

The Refresh button has not yet been converted to a glyph, but both of those files have a refresh button as well if you feel they are applicable.

[Pavel Feldman]

> The Refresh button has not yet been converted to a glyph, but both of those
> files have a refresh button as well if you feel they are applicable.

There is an Images/reloadButtonGlyph.png in place, it is just that .refresh-storage-status-bar-item was not updated to use it. Mikhail, could you add the fix into your patch?

[Mikhail Naganov]

Created attachment 34723 [details]
Storage view also converted to use StatusBarButton, fixed Reload button css to support glyph.

[Mikhail Naganov]

Joseph and Pavel, I've addressed your comments.

[Mikhail Naganov]

Created attachment 34724 [details]
noticed that I've accidentally made "Delete" button in Cookies view hidden---fixed

[Timothy Hatcher]

Comment on attachment 34724 [details]
noticed that I've accidentally made "Delete" button in Cookies view hidden---fixed

Nice!

[Pavel Feldman]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/WebCore.gypi
	M	WebCore/WebCore.vcproj/WebCore.vcproj
	M	WebCore/inspector/front-end/CookieItemsView.js
	M	WebCore/inspector/front-end/DOMStorageItemsView.js
	M	WebCore/inspector/front-end/ElementsPanel.js
	M	WebCore/inspector/front-end/Panel.js
	M	WebCore/inspector/front-end/ProfileView.js
	M	WebCore/inspector/front-end/ProfilesPanel.js
	M	WebCore/inspector/front-end/ResourcesPanel.js
	M	WebCore/inspector/front-end/ScriptsPanel.js
	M	WebCore/inspector/front-end/WebKit.qrc
	M	WebCore/inspector/front-end/inspector.css
	M	WebCore/inspector/front-end/inspector.html
Committed r47192