WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
281648
Make [JSManagedValue initWithValue:] more robust against clients using it from non-main threads
https://bugs.webkit.org/show_bug.cgi?id=281648
Summary
Make [JSManagedValue initWithValue:] more robust against clients using it fro...
Mark Lam
Reported
2024-10-16 22:14:12 PDT
[JSManagedValue initWithValue:] does not currently acquire the JS API lock because it expects to only be called on the JS main thread. However, it's easy for clients to make mistakes can call it from different threads. We should make [JSManagedValue initWithValue:] more robust by simply making it acquire the JS API lock for its VM.
rdar://138037948
Attachments
Add attachment
proposed patch, testcase, etc.
Mark Lam
Comment 1
2024-10-16 22:23:10 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/35344
Keith Miller
Comment 2
2024-10-22 14:30:22 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/35584
EWS
Comment 3
2024-10-28 10:35:59 PDT
Committed
285771@main
(596c3527f5dd): <
https://commits.webkit.org/285771@main
> Reviewed commits have been landed. Closing PR #35584 and removing active labels.
EWS
Comment 4
2024-11-05 17:42:32 PST
Committed
283286.432@safari-7620-branch
(4b20e20ab3de): <
https://commits.webkit.org/283286.432@safari-7620-branch
> Reviewed commits have been landed. Closing PR #2196 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug