WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
281642
AX: AXIsolatedTree::{collectNodeChangesForSubtree, removeSubtreeFromNodeMap} modify m_nodeMap children IDs when they shouldn't
https://bugs.webkit.org/show_bug.cgi?id=281642
Summary
AX: AXIsolatedTree::{collectNodeChangesForSubtree, removeSubtreeFromNodeMap} ...
Tyler Wilcock
Reported
2024-10-16 19:30:56 PDT
A key component of AXIsolatedTree::updateChildren is comparing the "old" children (what is in the node map) for an object vs. it's new children (the result of AccessibilityObject::children()). This makes AXIsolatedTree::{collectNodeChangesForSubtree, removeSubtreeFromNodeMap}'s behavior of modifying the children IDs for existing entries in the node map problematic, as that can happen before we've had a chance to call `updateChildren`, thus making the old and new children "match" even though they have actually changed since we last ran `updateChildren`. This means we won't create a new node change for this object, resulting in stale properties and missing children.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2024-10-16 19:31:09 PDT
<
rdar://problem/138083925
>
Tyler Wilcock
Comment 2
2024-10-16 19:42:17 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/35339
EWS
Comment 3
2024-10-17 11:36:28 PDT
Committed
285352@main
(2206f4c04ec4): <
https://commits.webkit.org/285352@main
> Reviewed commits have been landed. Closing PR #35339 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug