RESOLVED FIXED Bug 28163
bugzilla-tool: scm module should not import bugzilla module 
https://bugs.webkit.org/show_bug.cgi?id=28163
Summary bugzilla-tool: scm module should not import bugzilla module
David Kilzer (:ddkilzer)
Reported 2009-08-10 13:17:12 PDT
Created attachment 34505 [details] Patch v1 Reviewed by NOBODY (OOPS!). * Scripts/bugzilla-tool: (parse_bug_id): Added. Moved from CommitMessage.parse_bug_id() in scm module. * Scripts/modules/scm.py: Removed import of bugzilla module. (CommitMessage.parse_bug_id): Deleted. --- 3 files changed, 23 insertions(+), 12 deletions(-)
Attachments
Patch v1 (3.01 KB, patch)
2009-08-10 13:17 PDT, David Kilzer (:ddkilzer) 		levin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2009-08-10 13:22:17 PDT
Comment on attachment 34505 [details] Patch v1 Where did the loop go?
David Levin
Comment 2 2009-08-10 13:29:04 PDT
Comment on attachment 34505 [details] Patch v1 The loop went away because it now searches the whole message at once instead of one line at a time. commit_message.message() vs self.message_lines
David Levin
Comment 3 2009-08-10 13:30:13 PDT
And of course, please fix this on commit: http://webkit.org/b/00000
David Kilzer (:ddkilzer)
Comment 4 2009-08-10 14:50:47 PDT
(In reply to comment #3) > And of course, please fix this on commit: http://webkit.org/b/00000 It's already fixed locally. Thanks.
David Kilzer (:ddkilzer)
Comment 5 2009-08-10 14:53:55 PDT
$ git svn dcommit Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKitTools/ChangeLog M WebKitTools/Scripts/bugzilla-tool M WebKitTools/Scripts/modules/scm.py Committed r47005 http://trac.webkit.org/changeset/47005
Note You need to log in before you can comment on or make changes to this bug.