Bug 28162 - [Qt] QtLauncher crashes when trying to change zoom level
Summary: [Qt] QtLauncher crashes when trying to change zoom level
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2009-08-10 12:57 PDT by George Wright
Modified: 2009-08-12 15:49 PDT (History)
1 user (show)

See Also:

Fix QtLauncher crash (1.34 KB, patch)
2009-08-10 14:15 PDT, George Wright
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description George Wright 2009-08-10 12:57:44 PDT
Trying to change zoom level on QtLauncher causes the app to abort and exit:

george@iridium ~/gwright-sandbox/WebKitBuild/Debug/bin $ ./QtLauncher
ASSERT: "i >= 0" in file /home/george/gwright-sandbox/WebKit/qt/QtLauncher/main.cpp, line 169
zsh: abort      ./QtLauncher
Comment 1 George Wright 2009-08-10 14:15:25 PDT
Created attachment 34513 [details]
Fix QtLauncher crash

The zoomLevels object is only populated if a valid URL is passed to the application on launch, and it is never populated otherwise. This patch simply populates the zoom level no matter whether a valid URL is supplied or not as it does not depend on a valid URL to function correctly.
Comment 2 Eric Seidel (no email) 2009-08-12 15:26:48 PDT
Comment on attachment 34513 [details]
Fix QtLauncher crash

Adam, since you're a committer, you can just mark this commit-queue+ if you want it committed for you. :)  cq=? is for folks who are not committed but want to make sure it's added to the cq.
Comment 3 Eric Seidel (no email) 2009-08-12 15:49:23 PDT
Comment on attachment 34513 [details]
Fix QtLauncher crash

Clearing flags on attachment: 34513

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebKit/qt/ChangeLog
	M	WebKit/qt/QtLauncher/main.cpp
Committed r47156
	M	WebKit/qt/QtLauncher/main.cpp
	M	WebKit/qt/ChangeLog
r47156 = 2a552d79fea80795059ae47a478f535d24093bdd (trunk)
No changes between current HEAD and refs/remotes/trunk
Resetting to the latest refs/remotes/trunk
Comment 4 Eric Seidel (no email) 2009-08-12 15:49:27 PDT
All reviewed patches have been landed.  Closing bug.