Bug 28162 – [Qt] QtLauncher crashes when trying to change zoom level

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Qt

[George Wright]

Trying to change zoom level on QtLauncher causes the app to abort and exit:

george@iridium ~/gwright-sandbox/WebKitBuild/Debug/bin $ ./QtLauncher
ASSERT: "i >= 0" in file /home/george/gwright-sandbox/WebKit/qt/QtLauncher/main.cpp, line 169
zsh: abort      ./QtLauncher

[George Wright]

Created attachment 34513 [details]
Fix QtLauncher crash

The zoomLevels object is only populated if a valid URL is passed to the application on launch, and it is never populated otherwise. This patch simply populates the zoom level no matter whether a valid URL is supplied or not as it does not depend on a valid URL to function correctly.

[Eric Seidel (no email)]

Comment on attachment 34513 [details]
Fix QtLauncher crash

Adam, since you're a committer, you can just mark this commit-queue+ if you want it committed for you. :)  cq=? is for folks who are not committed but want to make sure it's added to the cq.

[Eric Seidel (no email)]

Comment on attachment 34513 [details]
Fix QtLauncher crash

Clearing flags on attachment: 34513

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebKit/qt/ChangeLog
	M	WebKit/qt/QtLauncher/main.cpp
Committed r47156
	M	WebKit/qt/QtLauncher/main.cpp
	M	WebKit/qt/ChangeLog
r47156 = 2a552d79fea80795059ae47a478f535d24093bdd (trunk)
No changes between current HEAD and refs/remotes/trunk
Resetting to the latest refs/remotes/trunk
http://trac.webkit.org/changeset/47156

[Eric Seidel (no email)]

All reviewed patches have been landed.  Closing bug.