WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
281616
Simplify socket ownership in ConnectionUnix.cpp
https://bugs.webkit.org/show_bug.cgi?id=281616
Summary
Simplify socket ownership in ConnectionUnix.cpp
Michael Catanzaro
Reported
2024-10-16 13:39:54 PDT
Currently the file descriptor m_socketDescriptor exists on all platforms but is owned only on non-GLib platforms. On GLib platforms, this file descriptor is owned by m_socket instead. This is slightly confusing, and unnecessary; we can simply get rid of m_socketDescriptor when using GLib.
Attachments
Add attachment
proposed patch, testcase, etc.
Michael Catanzaro
Comment 1
2024-10-16 13:54:28 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/35314
EWS
Comment 2
2024-10-17 07:45:26 PDT
Committed
285337@main
(392e377b4d13): <
https://commits.webkit.org/285337@main
> Reviewed commits have been landed. Closing PR #35314 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug