Bug 28161 – Qt DumpRenderTree does not process named events.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Mike Fenton]

The DumpRenderTree does not correctly process named events as used by the tests.

Named events currently processed by Mac/Win and not handled by Qt include:

leftArrow 
rightArrow
upArrow
downArrow
pageUp
pageDown
home
end
delete

Processing of these events needs to be added to the Qt DRT.

This bug was discovered by the failure of fast/forms/textarea-arrow-navigation.html which was moved from editing/input and was relying on editing.js, which is no longer references by the test, but uses eventSender("downArrow") instead.

[Mike Fenton]

Created attachment 34500 [details]
Code change for DumpRenderTree keyDown processing.

This patch fixes the existing test and enables all missing string based key events.  

Existing tests in skipped also need to be tested for other tests now fixed by this change.

[Mike Fenton]

Created attachment 34504 [details]
Style patch for jsobjects.cpp based upon results of cpp_style.py and WebKit style guide.

[Mike Fenton]

Created attachment 34555 [details]
Fix missing brace in previous patch.

[Adam Treat]

Comment on attachment 34500 [details]
Code change for DumpRenderTree keyDown processing.

This is awesome!  I imagine this will fix quite a few tests :)

A few comments:

> +    } else {
> +        qDebug() << ">>>>>>>>> keyDown" << string;

Is this necessary?

> +        // map special keycode strings used by the tests to something that works for Qt/X11
> +        if (string == "leftArrow") {

string == QLatin1String("leftArrow") I think.  r- to change.  And then I'll land :)

[Mike Fenton]

Created attachment 34562 [details]
Revised code change wrapping strings with QLatin1String()

[Mike Fenton]

Created attachment 34577 [details]
Remove working tests from qt/Skipped associated with DRT update.

[Adam Treat]

Comment on attachment 34562 [details]
Revised code change wrapping strings with QLatin1String()

Landed with r47077, clearing review flag.

[Eric Seidel (no email)]

Comment on attachment 34555 [details]
Fix missing brace in previous patch.

LGTM.

[Adam Treat]

Comment on attachment 34577 [details]
Remove working tests from qt/Skipped associated with DRT update.

Clear flags as this has landed.

[Eric Seidel (no email)]

Comment on attachment 34555 [details]
Fix missing brace in previous patch.

Rejecting patch 34555 from commit-queue.  This patch will require manual commit.

Failed to run "['git', 'svn', 'dcommit']"  exit_code: 1  cwd: None

[Eric Seidel (no email)]

ChangeLog diff is malformed.  bugzilla-tool/svn-apply don't know how to fix it, hence the commit-queue rejected it.

[Mike Fenton]

Created attachment 34667 [details]
Replacement patch with proper ChangeLog Entry

Here's a fixed patch with the changeLog entry complete.

[Eric Seidel (no email)]

Comment on attachment 34555 [details]
Fix missing brace in previous patch.

clearing review flag on this obsolete patch.

[Adam Treat]

Landed with r47358.  Closing bug...