WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
281609
Make UnixFileDescriptor noncopyable again
https://bugs.webkit.org/show_bug.cgi?id=281609
Summary
Make UnixFileDescriptor noncopyable again
Michael Catanzaro
Reported
2024-10-16 12:37:16 PDT
Make UnixFileDescriptor noncopyable again. Otherwise, it's very difficult to use the class without accidentally duping the file descriptor. This is a partial revert of
272365@main
. We can manually duplicate the file descriptor in the SharedMemoryHandle copy constructor, since we really do want a copy there. This un-reverts
261281@main
.
Attachments
Add attachment
proposed patch, testcase, etc.
Michael Catanzaro
Comment 1
2024-10-16 12:39:41 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/35306
EWS
Comment 2
2024-10-17 07:43:27 PDT
Committed
285336@main
(ef66440cf7fc): <
https://commits.webkit.org/285336@main
> Reviewed commits have been landed. Closing PR #35306 and removing active labels.
Radar WebKit Bug Importer
Comment 3
2024-10-17 07:44:16 PDT
<
rdar://problem/138112700
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug