RESOLVED FIXED 281599
Disable line-fit-edge by default 
https://bugs.webkit.org/show_bug.cgi?id=281599
Summary Disable line-fit-edge by default
fantasai
Reported 2024-10-16 11:18:50 PDT
The CSSWG resolved that: - text-box-trim trims an inline box to its text-box-edge for painting purposes; and if line-fit-edge is not its initial value, also for sizing purposes - otherwise, if line-fit-edge is not its initial value they use the line-fit-edge both for sizing and for painting backgrounds and borders
Attachments
testcase for painting (577 bytes, text/html)
2024-10-16 11:24 PDT, fantasai 		no flags
Details
testcase for sizing (689 bytes, text/html)
2024-10-16 12:01 PDT, fantasai 		no flags
Details
Patch (16.18 KB, patch)
2024-10-22 20:36 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (17.77 KB, patch)
2024-10-23 08:45 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (17.77 KB, patch)
2024-10-23 10:30 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (20.79 KB, patch)
2024-10-23 14:54 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (18.94 KB, patch)
2024-10-23 16:12 PDT, zalan 		no flags
DetailsFormatted DiffDiff
[fast-cq]Patch (23.24 KB, patch)
2024-10-23 19:50 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 2 2024-10-16 11:19:57 PDT
<rdar://problem/138051733>
fantasai
Comment 3 2024-10-16 11:24:46 PDT
Created attachment 472956 [details] testcase for painting
fantasai
Comment 4 2024-10-16 11:40:39 PDT
Also, if you're trimming the span that won't have any effect on the paragraph. You need to trim the paragraph to affect the paragraph.
fantasai
Comment 5 2024-10-16 11:41:26 PDT
(Sorry, typed into the wrong window. >_<;;)
fantasai
Comment 6 2024-10-16 12:01:29 PDT
Created attachment 472958 [details] testcase for sizing Not 100% sure this is correct, but it's my attempt at a sizing test.
zalan
Comment 7 2024-10-22 20:36:58 PDT
Created attachment 473014 [details] Patch
zalan
Comment 8 2024-10-23 08:45:20 PDT
Created attachment 473018 [details] Patch
zalan
Comment 9 2024-10-23 10:30:59 PDT
Created attachment 473019 [details] Patch
Tim Nguyen (:ntim)
Comment 10 2024-10-23 13:41:05 PDT
We're planning to disable line-fit-edge until the spec is more stable atm.
zalan
Comment 11 2024-10-23 14:54:51 PDT
Created attachment 473024 [details] Patch
zalan
Comment 12 2024-10-23 16:12:13 PDT
Created attachment 473026 [details] Patch
zalan
Comment 13 2024-10-23 19:50:18 PDT
Created attachment 473028 [details] [fast-cq]Patch
EWS
Comment 14 2024-10-24 05:10:21 PDT
Committed 285645@main (68666f27e2e2): <https://commits.webkit.org/285645@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 473028 [details].
EWS
Comment 15 2024-11-01 10:36:57 PDT
Committed 283286.404@safari-7620-branch (2a968afef599): <https://commits.webkit.org/283286.404@safari-7620-branch> Reviewed commits have been landed. Closing PR #2169 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.