Bug 28158 - create-bug throws an exception if --cc is not specified
Summary: create-bug throws an exception if --cc is not specified
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-10 11:48 PDT by Adam Roben (:aroben)
Modified: 2009-08-12 10:23 PDT (History)
1 user (show)

See Also:

Attachments
Patch v1 (1.29 KB, patch)
2009-08-10 11:48 PDT, Adam Roben (:aroben) 		ddkilzer: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2009-08-10 11:48:43 PDT 
Created attachment 34493 [details]
Patch v1

To reproduce:

1. bugzilla-tool create-bug

After filling in all the appropriate information, an exception is thrown:

Traceback (most recent call last):
  File "/home/Adam Roben/dev/WebKit/OpenSource/WebKitTools/Scripts/bugzilla-tool", line 690, in <module>
    main()
  File "/home/Adam Roben/dev/WebKit/OpenSource/WebKitTools/Scripts/bugzilla-tool", line 687, in main
    return tool.main()
  File "/home/Adam Roben/dev/WebKit/OpenSource/WebKitTools/Scripts/bugzilla-tool", line 682, in main
    return command_object.execute(command_options, command_args, self)
  File "/home/Adam Roben/dev/WebKit/OpenSource/WebKitTools/Scripts/bugzilla-tool", line 543, in execute
    self.create_bug_from_patch(options, args, tool)
  File "/home/Adam Roben/dev/WebKit/OpenSource/WebKitTools/Scripts/bugzilla-tool", line 522, in create_bug_from_patch
    bug_id = tool.bugs.create_bug_with_patch(bug_title, comment_text, options.component, diff_file, "Patch v1", cc=options.cc, mark_for_review=options.review)
  File "/cygdrive/h/cyghome/dev/WebKit/OpenSource/WebKitTools/Scripts/modules/bugzilla.py", line 307, in create_bug_with_patch
    self.browser['cc'] = cc
  File "/usr/lib/python2.5/site-packages/ClientForm-0.2.10-py2.5.egg/ClientForm.py", line 2897, in __setitem__
  File "/usr/lib/python2.5/site-packages/ClientForm-0.2.10-py2.5.egg/ClientForm.py", line 1336, in __setattr__
TypeError: must assign a string
Comment 1 David Kilzer (:ddkilzer) 2009-08-10 11:53:44 PDT 
Comment on attachment 34493 [details]
Patch v1

r=me
Comment 2 Adam Roben (:aroben) 2009-08-12 10:23:23 PDT 
Fixed in r47120 http://trac.webkit.org/changeset/47120