Bug 28151 - KURL hasFragmentIdentifier()/removeFragmentIdentifier() should be cleaned up and made a little smarter
Summary: KURL hasFragmentIdentifier()/removeFragmentIdentifier() should be cleaned up ...
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 37641
  Show dependency tree / graph
 
Reported: 2009-08-10 09:41 PDT by Brady Eidson
Modified: 2023-05-22 03:44 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2009-08-10 09:41:14 PDT 
KURL hasFragmentIdentifier()/removeFragmentIdentifier() should be cleaned up and made a little smarter.

There's a handful of callsites that always say:
if (someURL.hasFragmentIdentifier())
    someURL.removeFragmentIdentifier();

Which is kind of silly and might be cleaner as one line of code...
...except that removeFragmentIdentifier() always allocs a new string and reparses it, when it should really do its own "if I don't have a fragment ID, don't do anything" check.
Comment 1 Anne van Kesteren 2023-05-22 03:44:35 PDT 
KURL is gone.