WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
28147
Qt build skips fast/borders/border-radius-split-inline.html when it is unnecessary
https://bugs.webkit.org/show_bug.cgi?id=28147
Summary
Qt build skips fast/borders/border-radius-split-inline.html when it is unnece...
Mike Fenton
Reported
2009-08-10 08:04:49 PDT
Currently the test fast/borders/border-radius-split-inline.html is being skipped because of questionable results, however, results should be added as the test is in fact functioning correctly. The test sets up the css to split a string at 200px, which according to the test (and text used in the test) should result in the string being split over 3 lines. However, in qtwebkit, the font drawing results in this test being drawn over 4 lines instead of 3, while still maintaining the split at 200px, which is what the test is designed to verify. NOTE: When compared with the drawing in FireFox, the test is also split across 4 lines visually appearing identical to the results of running in QtLauncher.
Attachments
Patch to remove border-radius-split-inline from platform/qt/Skipped and add test results.
(2.22 KB, patch)
2009-08-10 08:23 PDT
,
Mike Fenton
no flags
Details
Formatted Diff
Diff
Replace patch with extended ChangeLog.
(2.38 KB, patch)
2009-08-10 09:28 PDT
,
Mike Fenton
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Mike Fenton
Comment 1
2009-08-10 08:23:50 PDT
Created
attachment 34475
[details]
Patch to remove border-radius-split-inline from platform/qt/Skipped and add test results.
Eric Seidel (no email)
Comment 2
2009-08-10 09:01:08 PDT
Comment on
attachment 34475
[details]
Patch to remove border-radius-split-inline from platform/qt/Skipped and add test results. More of the bug description should have been in the ChangeLog. Specifically that the results match FF even though they disagree with other webkit port expectations. Do you believe this test just needs to be re-written? Do we know why it's wrapping to 4 lines? I assume font-sizing differences?
Mike Fenton
Comment 3
2009-08-10 09:28:43 PDT
Created
attachment 34477
[details]
Replace patch with extended ChangeLog. Updated patch with more detailed Changelog. The extra wrapping is due to the font size as surmised. The original test could also be changed to not provide a number of lines but as this currently is only affecting the Qt port, I don't know that it warrants changing the test for every platform.
Kenneth Rohde Christiansen
Comment 4
2009-08-11 09:48:51 PDT
Comment on
attachment 34477
[details]
Replace patch with extended ChangeLog. Landed in 47034
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug