Bug 28147 - Qt build skips fast/borders/border-radius-split-inline.html when it is unnecessary
: Qt build skips fast/borders/border-radius-split-inline.html when it is unnece...
Status: RESOLVED FIXED
: WebKit
New Bugs
: 528+ (Nightly build)
: PC Linux
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2009-08-10 08:04 PST by
Modified: 2009-08-11 09:49 PST (History)


Attachments
Patch to remove border-radius-split-inline from platform/qt/Skipped and add test results. (2.22 KB, patch)
2009-08-10 08:23 PST, Mike Fenton
no flags Review Patch | Details | Formatted Diff | Diff
Replace patch with extended ChangeLog. (2.38 KB, patch)
2009-08-10 09:28 PST, Mike Fenton
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2009-08-10 08:04:49 PST
Currently the test fast/borders/border-radius-split-inline.html is being skipped because of questionable results, however, results should be added as the test is in fact functioning correctly.

The test sets up the css to split a string at 200px, which according to the test (and text used in the test) should result in the string being split over 3 lines.

However, in qtwebkit, the font drawing results in this test being drawn over 4 lines instead of 3, while still maintaining the split at 200px, which is what the test is designed to verify.

NOTE: When compared with the drawing in FireFox, the test is also split across 4 lines visually appearing identical to the results of running in QtLauncher.
------- Comment #1 From 2009-08-10 08:23:50 PST -------
Created an attachment (id=34475) [details]
Patch to remove border-radius-split-inline from platform/qt/Skipped and add test results.
------- Comment #2 From 2009-08-10 09:01:08 PST -------
(From update of attachment 34475 [details])
More of the bug description should have been in the ChangeLog.  Specifically that the results match FF even though they disagree with other webkit port expectations.

Do you believe this test just needs to be re-written?  Do we know why it's wrapping to 4 lines?  I assume font-sizing differences?
------- Comment #3 From 2009-08-10 09:28:43 PST -------
Created an attachment (id=34477) [details]
Replace patch with extended ChangeLog.

Updated patch with more detailed Changelog.  

The extra wrapping is due to the font size as surmised.  The original test could also be changed to not provide a number of lines but as this currently is only affecting the Qt port, I don't know that it warrants changing the test for every platform.
------- Comment #4 From 2009-08-11 09:48:51 PST -------
(From update of attachment 34477 [details])
Landed in 47034