WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
281412
Change the StringBuilder in stringReplaceAllStringString to RecordOverflow.
https://bugs.webkit.org/show_bug.cgi?id=281412
Summary
Change the StringBuilder in stringReplaceAllStringString to RecordOverflow.
Mark Lam
Reported
2024-10-13 23:29:59 PDT
The function was already checking for resultBuilder.hasOverflowed(), but without this RecordOverflow handler being explicitly specified, the StringBuilder will crash eagerly on detected overflow.
rdar://137230737
Attachments
Add attachment
proposed patch, testcase, etc.
Mark Lam
Comment 1
2024-10-13 23:33:26 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/35135
EWS
Comment 2
2024-10-14 09:47:13 PDT
Committed
285126@main
(48e051485568): <
https://commits.webkit.org/285126@main
> Reviewed commits have been landed. Closing PR #35135 and removing active labels.
EWS
Comment 3
2024-10-15 18:38:01 PDT
Committed
283286.290@safari-7620-branch
(41ac999f8a8b): <
https://commits.webkit.org/283286.290@safari-7620-branch
> Reviewed commits have been landed. Closing PR #2032 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug