Bug 28136 - Need to refactor WorkerObjectProxy
Summary: Need to refactor WorkerObjectProxy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Andrew Wilson
URL:
Keywords:
Depends on:
Blocks: 28170
  Show dependency treegraph
 
Reported: 2009-08-09 21:34 PDT by Andrew Wilson
Modified: 2009-08-11 09:33 PDT (History)
1 user (show)

See Also:


Attachments
proposed patch (28.08 KB, patch)
2009-08-09 21:52 PDT, Andrew Wilson
levin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Wilson 2009-08-09 21:34:00 PDT
Some of the APIs in WorkerObjectProxy are also useful for SharedWorkers - we should refactor the common APIs into a separate class.
Comment 1 Andrew Wilson 2009-08-09 21:52:40 PDT
Created attachment 34439 [details]
proposed patch

This is the first part of my upcoming patch that adds lifecycle management for shared workers.
Comment 2 David Levin 2009-08-11 02:03:19 PDT
Comment on attachment 34439 [details]
proposed patch

> diff --git a/WebCore/workers/WorkerReportingProxy.h b/WebCore/workers/WorkerReportingProxy.h

> +
> +    // APIs used by workers to report console activity.
> +    class WorkerReportingProxy {
> +    public:
> +        virtual ~WorkerReportingProxy() {}
Nice to add a space in the {}
Comment 3 Andrew Wilson 2009-08-11 09:33:47 PDT
Committed as r47036