Bug 28127 - [Haiku] Use Clipboard::create instead of its constructor.
Summary: [Haiku] Use Clipboard::create instead of its constructor.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-09 05:44 PDT by Maxime Simon
Modified: 2009-08-11 15:25 PDT (History)
2 users (show)

See Also:


Attachments
Use Clipboard::create() instead of the constructor of its class. (8.18 KB, patch)
2009-08-09 05:51 PDT, Maxime Simon
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Maxime Simon 2009-08-09 05:44:23 PDT
Some files are using the constructor of the Clipboard class. Here is a patch to avoid this and use the create() method instead.
There is also some style cleanup in ClipboardHaiku.cpp

Regards,
Maxime
Comment 1 Maxime Simon 2009-08-09 05:51:07 PDT
Created attachment 34415 [details]
Use Clipboard::create() instead of the constructor of its class.
Comment 2 Eric Seidel (no email) 2009-08-09 08:08:02 PDT
Comment on attachment 34415 [details]
Use Clipboard::create() instead of the constructor of its class.

LGTM.  Normally we try to split out functional changes from style changes, but this is OK.

Thanks for the patch!
Comment 3 Eric Seidel (no email) 2009-08-11 15:25:29 PDT
Comment on attachment 34415 [details]
Use Clipboard::create() instead of the constructor of its class.

Clearing review flag on attachment: 34415

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/editing/haiku/EditorHaiku.cpp
	M	WebCore/page/haiku/EventHandlerHaiku.cpp
	M	WebCore/platform/haiku/ClipboardHaiku.cpp
	M	WebCore/platform/haiku/DragDataHaiku.cpp
Committed r47068
	M	WebCore/editing/haiku/EditorHaiku.cpp
	M	WebCore/ChangeLog
	M	WebCore/page/haiku/EventHandlerHaiku.cpp
	M	WebCore/platform/haiku/ClipboardHaiku.cpp
	M	WebCore/platform/haiku/DragDataHaiku.cpp
r47068 = a6669f4fb846d758f172b3974b9f79bcd5242a69 (trunk)
No changes between current HEAD and refs/remotes/trunk
Resetting to the latest refs/remotes/trunk
http://trac.webkit.org/changeset/47068
Comment 4 Eric Seidel (no email) 2009-08-11 15:25:32 PDT
All reviewed patches have been landed.  Closing bug.