Patch to add the ScrollbarThemeHaiku.* files to WebCore.
Created attachment 34410 [details] Patch to add the ScrollbarTheme files for Haiku.
Comment on attachment 34410 [details] Patch to add the ScrollbarTheme files for Haiku. I would have written: return IntRect(scrollbar->x(), scrollbar->y(), 77 scrollbar->width() < 2 * thickness ? scrollbar->width() / 2 : thickness, thickness); 78 return IntRect(scrollbar->x(), scrollbar->y(), 79 thickness, scrollbar->height() < 2 * thickness ? scrollbar->height() / 2 : thickness); As: int buttonWidth(int scrollbarWidth, int thickness) { return scrollbarWidth < 2 * thickness ? scrollbarWidth / 2 : thickness; } IntPoint buttonOrigin(scrollbar->x(), scrollbar->y()); IntSize buttonSize = scrollbar->orientation() == HorizontalScrollbar ? IntSize(buttonWidth(scrollbar->width()), thickness) : IntSize(thickness, buttonWidth(scrollbar->width()); return IntRect(buttonOrigin, buttonSize); That way you can re-use buttonWidth() on the next function too. The code looks OK as is though.
Maxime, You should also add yourself above Apple in the copyright section of this code (and other code you have written or modified.) Though since Eric alread r+ this, you can make some new patches later to fix up the copyrights. Or consider also making the change Eric suggested and make a new patch. It's up to you ;)
Created attachment 34550 [details] Patch to add the ScrollbarTheme files for Haiku. Make some changes as suggested by Eric and Ryan, even if the previous patches was r+. I also made some style cleanup.
Created attachment 34564 [details] Patch to add the ScrollbarTheme files for Haiku. Sorry, the previous had a mistake. I changed scrollbar->height() to scrollbar->width(), so it didn't display correctly the back button.
Comment on attachment 34564 [details] Patch to add the ScrollbarTheme files for Haiku. I wouldn't have bothered to create this variable: 83 IntRect buttonRect(buttonOrigin, buttonSize); 84 85 return buttonRect; Looks fine though.
Comment on attachment 34564 [details] Patch to add the ScrollbarTheme files for Haiku. Clearing flags on attachment: 34564 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog A WebCore/platform/haiku/ScrollbarThemeHaiku.cpp A WebCore/platform/haiku/ScrollbarThemeHaiku.h Committed r47143 M WebCore/ChangeLog A WebCore/platform/haiku/ScrollbarThemeHaiku.cpp A WebCore/platform/haiku/ScrollbarThemeHaiku.h r47143 = 1e5acb63da2fefd1e799f6c31987d9899a34e057 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47143
All reviewed patches have been landed. Closing bug.