Bug 281211 – REGRESSION: ASSERTION FAILED: mode == Verify => !repaintRects() in WebCore::RenderLayer::recursiveUpdateLayerPositions on imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-animation-in-auto-subtree.html

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[WPE] [GTK]

STDERR: ASSERTION FAILED: mode == Verify => !repaintRects()
STDERR: /app/webkit/Source/WebCore/rendering/RenderLayer.cpp(1206) : WebCore::RenderLayer::recursiveUpdateLayerPositions<WebCore::RenderLayer::Verify>(WebCore::RenderElement::LayoutIdentifier, WTF::OptionSet<UpdateLayerPositionsFlag>, CanUseSimplifiedRepaintPass)::<lambda(bool)>
STDERR: 1   0x7f14a62efa0d WebCore::RenderLayer::recursiveUpdateLayerPositions<(WebCore::RenderLayer::UpdateLayerPositionsMode)1>(unsigned int, WTF::OptionSet<WebCore::RenderLayer::UpdateLayerPositionsFlag>, WebCore::RenderLayer::CanUseSimplifiedRepaintPass)::{lambda(bool)#1}::operator()(bool) const
STDERR: 2   0x7f14a62f046d void WebCore::RenderLayer::recursiveUpdateLayerPositions<(WebCore::RenderLayer::UpdateLayerPositionsMode)1>(unsigned int, WTF::OptionSet<WebCore::RenderLayer::UpdateLayerPositionsFlag>, WebCore::RenderLayer::CanUseSimplifiedRepaintPass)
STDERR: 3   0x7f14a62f0b45 void WebCore::RenderLayer::recursiveUpdateLayerPositions<(WebCore::RenderLayer::UpdateLayerPositionsMode)1>(unsigned int, WTF::OptionSet<WebCore::RenderLayer::UpdateLayerPositionsFlag>, WebCore::RenderLayer::CanUseSimplifiedRepaintPass)
STDERR: 4   0x7f14a62f0b45 void WebCore::RenderLayer::recursiveUpdateLayerPositions<(WebCore::RenderLayer::UpdateLayerPositionsMode)1>(unsigned int, WTF::OptionSet<WebCore::RenderLayer::UpdateLayerPositionsFlag>, WebCore::RenderLayer::CanUseSimplifiedRepaintPass)
STDERR: 5   0x7f14a62f0b45 void WebCore::RenderLayer::recursiveUpdateLayerPositions<(WebCore::RenderLayer::UpdateLayerPositionsMode)1>(unsigned int, WTF::OptionSet<WebCore::RenderLayer::UpdateLayerPositionsFlag>, WebCore::RenderLayer::CanUseSimplifiedRepaintPass)
STDERR: 6   0x7f14a62eae42 void WebCore::RenderLayer::recursiveUpdateLayerPositions<(WebCore::RenderLayer::UpdateLayerPositionsMode)0>(unsigned int, WTF::OptionSet<WebCore::RenderLayer::UpdateLayerPositionsFlag>, WebCore::RenderLayer::CanUseSimplifiedRepaintPass)
STDERR: 7   0x7f14a62c9f14 WebCore::RenderLayer::updateLayerPositionsAfterStyleChange()
STDERR: 8   0x7f14a56ae4d3 WebCore::LocalFrameView::updateCompositingLayersAfterStyleChange()
STDERR: 9   0x7f14a47e0378 WebCore::Document::resolveStyle(WebCore::Document::ResolveStyleType)
STDERR: 10  0x7f14a47e0b35 WebCore::Document::updateStyleIfNeeded()
STDERR: 11  0x7f14a405534b WebCore::ComputedStyleExtractor::updateStyleIfNeededForProperty(WebCore::Element&, WebCore::CSSPropertyID)
STDERR: 12  0x7f14a4058884 WebCore::ComputedStyleExtractor::propertyValue(WebCore::CSSPropertyID, WebCore::ComputedStyleExtractor::UpdateLayout, WebCore::ComputedStyleExtractor::PropertyValueType) const
STDERR: 13  0x7f14a3e86369 WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue(WebCore::CSSPropertyID, WebCore::ComputedStyleExtractor::UpdateLayout) const
STDERR: 14  0x7f14a3e865e2 WebCore::CSSComputedStyleDeclaration::getPropertyValue(WebCore::CSSPropertyID) const
STDERR: 15  0x7f14a3e86f78 WebCore::CSSComputedStyleDeclaration::getPropertyValueInternal(WebCore::CSSPropertyID)
STDERR: 16  0x7f14a3fae59c WebCore::CSSStyleDeclaration::propertyValueForCamelCasedIDLAttribute(WTF::AtomString const&)
STDERR: 17  0x7f14a15be222 jsCSSStyleDeclaration_propertyValueForCamelCasedIDLAttributeGetter
STDERR: 18  0x7f14a15cc64f getPassingPropertyName<WebCore::jsCSSStyleDeclaration_propertyValueForCamelCasedIDLAttributeGetter, (WebCore::CastedThisErrorBehavior)3>
STDERR: 19  0x7f14a15be2ae jsCSSStyleDeclaration_propertyValueForCamelCasedIDLAttribute
STDERR: 20  0x7f14914ee058 WTF::FunctionPtr<(WTF::PtrTag)57072, long (JSC::JSGlobalObject*, long, JSC::PropertyName), (WTF::FunctionAttributes)1>::operator()(JSC::JSGlobalObject*, long, JSC::PropertyName) const
STDERR: 21  0x7f1491799a8a JSC::PropertySlot::customGetter(JSC::VM&, JSC::PropertyName) const
STDERR: 22  0x7f148f8f195e JSC::PropertySlot::getValue(JSC::JSGlobalObject*, JSC::PropertyName) const
STDERR: 23  0x7f148f91aff4 JSC::JSValue::get(JSC::JSGlobalObject*, JSC::PropertyName, JSC::PropertySlot&) const
STDERR: 24  0x7f14910b20d5 performLLIntGetByID
STDERR: 25  0x7f14910b293c llint_slow_path_get_by_id
STDERR: 26  0x7f148f880ddb llint_op_get_by_id
STDERR: WebKitWebProcess terminated (pid 543047) for reason: crash

History
https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-contain%2Fcontent-visibility%2Fcontent-visibility-animation-in-auto-subtree.html

The assertion was added by 284780@main.

[Alexey Proskuryakov]

FWIW, we're not seeing this on macOS or iOS bots.

[Fujii Hironori]

Because Mac port Debug build enable ENABLE_CONJECTURE_ASSERT, LAYER_POSITIONS_ASSERT_IMPLIES is CONJECTURE_ASSERT_IMPLIES on Mac Debug build.
So, you have to set __XPC_ENABLE_WEBKIT_CONJECTURE_ASSERT env var for Mac Debug.

> ./Tools/Scripts/run-webkit-tests --debug --no-build --additional-env-var=__XPC_ENABLE_WEBKIT_CONJECTURE_ASSERT=1 imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-animation-in-auto-subtree.html

However, I observe another conjection assertion failure (bug#281041) for this test.

[EWS]

Committed 285067@main (b0aeb21b0181): <https://commits.webkit.org/285067@main>

Reviewed commits have been landed. Closing PR #35101 and removing active labels.

[Radar WebKit Bug Importer]

<rdar://problem/137797092>

[Claudio Saavedra]

(In reply to EWS from comment #4)
> Committed 285067@main (b0aeb21b0181):
> <https://commits.webkit.org/285067@main>
> 
> Reviewed commits have been landed. Closing PR #35101 and removing active
> labels.


Reopening, not sure why landing that commit confused the infrastructure and this got closed.

[Tim Nguyen (:ntim)]

(In reply to Claudio Saavedra from comment #6)
> (In reply to EWS from comment #4)
> > Committed 285067@main (b0aeb21b0181):
> > <https://commits.webkit.org/285067@main>
> > 
> > Reviewed commits have been landed. Closing PR #35101 and removing active
> > labels.
> 
> 
> Reopening, not sure why landing that commit confused the infrastructure and
> this got closed.

You wrote "Unreviewed gardening." instead of "Unreviewed test gardening." which the current tooling does not recognize.

This crash doesn't happen any more, likely due to changes at https://github.com/WebKit/WebKit/pull/35021. Close now.

[Claudio Saavedra]

There are still tests in glib/TestExpectations that are referencing this bug, reopening.

[Claudio Saavedra]

Turns out they are all passing now (or failing for unrelated reason), so this can be closed. Gardened in https://commits.webkit.org/289668@main