RESOLVED FIXED 281156
[ANGLE] Allow envvar to gate ASSERT at runtime 
https://bugs.webkit.org/show_bug.cgi?id=281156
Summary [ANGLE] Allow envvar to gate ASSERT at runtime
zak ridouh
Reported 2024-10-09 12:00:05 PDT
Add a `ANGLE_ASSERTS_OFF` environment variable that allows us to disable asserts at runtime regardless of how ANGLE was built. This is necessary due to how some of our build systems work, where we need to be able to disable asserts at runtime regardless of if we built ANGLE with the `ANGLE_ASSERT_ALWAYS_ON` or `ANGLE_ENABLE_ASSERTS` flag set. We cache the value from the `envvar`, so that we don't incur a `getenv` check on every ASSERT. Additionally, this will not impact release builds as this function is gated by a guard: `#if defined(ANGLE_ENABLE_ASSERTS)`.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2024-10-09 12:00:18 PDT
<rdar://problem/137613945>
zak ridouh
Comment 2 2024-10-09 12:04:39 PDT
Pull request: https://github.com/WebKit/WebKit/pull/34919
Fujii Hironori
Comment 3 2024-10-09 13:25:07 PDT
FWIW, We have ENABLE_WEBKIT_CONJECTURE_ASSERT env var for WebKit. bug#277938 I don't mean you have to use the same env var.
EWS
Comment 4 2024-11-07 15:23:32 PST
Committed 286306@main (0e0d62f0b2e8): <https://commits.webkit.org/286306@main> Reviewed commits have been landed. Closing PR #34919 and removing active labels.
EWS
Comment 5 2024-11-07 16:13:52 PST
Committed 286307@main (aff0b1e3ced7): <https://commits.webkit.org/286307@main> Reviewed commits have been landed. Closing PR #36353 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.