Bug 28114 – [ES5] Implement Object.getPrototypeOf

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Oliver Hunt]

ES5 defines a standard getPrototypeOf in place of __proto__, we should implement this

[Oliver Hunt]

Created attachment 34399 [details]
Patch v1

[Eric Seidel (no email)]

Comment on attachment 34399 [details]
Patch v1

Do we want to guard this in any way?  I don't know how up-in-the-air ES5 is at this point.

Technically this looks fine.

I guess isPrototypeOf was implemented before but just not well tested? (Since I don't see the implementation of isPrototypeOf here.

Since this technically looks fine, and I trust you to make a guarding decision, r+. :)  (I even went and read the spec.)

You might consider adding the spec text to your ChangeLog:

15.2.3.2 Object.getPrototypeOf ( O ) 
When the getPrototypeOf function is called with argument O, the following steps are taken: 
1. If Type(O) is not Object throw a TypeError exception. 
2. Return the value of the [[Prototype]] internal property of O.

[Sam Weinig]

Comment on attachment 34399 [details]
Patch v1

> +static JSValue JSC_HOST_CALL objectConsGetPrototypeOf(ExecState*, JSObject*, JSValue, const ArgList&);

Please don't abbreviate constructor here.  I have tried hard to keep unnecessary abbreviations out of these methods.

[Oliver Hunt]

Committed r46963