Bug 281136 – webkit-line-clamp in nested context does not render ellipsis when inline content fits.

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Karl Dubost]

Created attachment 472879 [details]
testcase

See the testcase in the attachment, only on Safari the text doesn't get proper ellipsis. 

Initially reported on https://oisaur.com/@renchap/113276852782235890
but wrongly attributed to Bug 5990, which is a different bug.

[Radar WebKit Bug Importer]

<rdar://problem/137585973>

[Renaud Chaput]

Created attachment 472880 [details]
testcase-not-lists

This bug is not specific to lists, it also happens if for example the content is multiple <p> tags.

[zalan]

(In reply to Renaud Chaput from comment #2)
> Created attachment 472880 [details]
> testcase-not-lists
> 
> This bug is not specific to lists, it also happens if for example the
> content is multiple <p> tags.
Do you mind adding a test case, please? The codepen shows ellipsis on the second (<p>) example on trunk webkit.

[zalan]

never mind, I didn't see the test case. Thank you.

[zalan]

This bugs (not rendering ellipsis) seems to happen when the content actually fits.

[zalan]

Created attachment 472881 [details]
Test reduction

[zalan]

(In reply to zalan from comment #5)
> This bugs (not rendering ellipsis) seems to happen when the content actually
> fits.
in block direction (i.e. clamping direction)

[zalan]

This is the classic "last formatting line" bug where individual inline formatting contexts can't decided whether ellipsis is required or not on their _last_ line since they can't tell if that's the actual _last_ line in the line clamp context (as we are not supposed to put ellipsis when the clamped line is the actual _last_ line in the clamp context)
e.g.
<div clamp=1>
  <div>this is the last line both in this FC and in the clamp context</div>
</div>

vs.

<div clamp=1>
  <div>this is the last line in this formatting context</div>
  <div>this is the last line both in this FC and in the clamp context</div>
</div>

where only the second case should show ellipsis.

[zalan]

(In reply to zalan from comment #8)
> This is the classic "last formatting line" bug where individual inline
"last formatting line" should read "last formatted line"

I'm facing the same issue (Safari Version 18.1.1 (20619.2.8.11.12)): https://codepen.io/CyrilKrylatov/pen/dPbYOEK

[zalan]

Created attachment 473452 [details]
Patch

[zalan]

Created attachment 473458 [details]
Patch

[zalan]

Created attachment 473478 [details]
Patch

[zalan]

Created attachment 473481 [details]
[fast-cq]Patch

[EWS]

Committed 287441@main (8ea2903a98c4): <https://commits.webkit.org/287441@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 473481 [details].