RESOLVED FIXED 281089
REGRESSION(284750@main): [macOS iOS Debug] ASSERTION FAILED: !child->frameID in http/tests/site-isolation/draw-after-cross-origin-navigation-between-two-remote-frames.html result of flaky timeouts 
https://bugs.webkit.org/show_bug.cgi?id=281089
Summary REGRESSION(284750@main): [macOS iOS Debug] ASSERTION FAILED: !child->frameID ...
Marta Darbinyan
Reported 2024-10-08 14:23:13 PDT
http/tests/site-isolation/draw-after-cross-origin-navigation-between-two-remote-frames.html is regressed with flaky timeout instances in macOS Debug after 284750@main. The test is pre-existing failure in macOS EWS. Error logs: ASSERTION FAILED: !child->frameID() || !childItemWithFrameID(*child->frameID()) /Volumes/Data/worker/macOS-Sonoma-Debug-WK2-Tests-EWS/build/Source/WebCore/history/HistoryItem.cpp(326) : void WebCore::HistoryItem::addChildItem(Ref<HistoryItem> &&) 1 0x33293307c WebCore::HistoryItem::addChildItem(WTF::Ref<WebCore::HistoryItem, WTF::RawPtrTraits<WebCore::HistoryItem>, WTF::DefaultRefDerefTraits<WebCore::HistoryItem>>&&) 2 0x1298a1a5c WebKit::applyFrameState(WebCore::HistoryItemClient&, WebCore::HistoryItem&, WebKit::FrameState const&) 3 0x1298a1690 WebKit::toHistoryItem(WebCore::HistoryItemClient&, WebKit::FrameState const&) 4 0x12a0a6be8 WebKit::WebPage::restoreSessionInternal(WTF::Vector<WTF::Ref<WebKit::FrameState, WTF::RawPtrTraits<WebKit::FrameState>, WTF::DefaultRefDerefTraits<WebKit::FrameState>>, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&, WebKit::WebPage::WasRestoredByAPIRequest, WebKit::WebBackForwardListProxy::OverwriteExistingItem) 5 0x12a0a1fe8 WebKit::WebPage::WebPage(WTF::ObjectIdentifierGeneric<WebCore::PageIdentifierType, WTF::ObjectIdentifierMainThreadAccessTraits<unsigned long long>, unsigned long long, (WTF::SupportsObjectIdentifierNullState)0>, WebKit::WebPageCreationParameters&&) 6 0x12a0a008c WebKit::WebPage::WebPage(WTF::ObjectIdentifierGeneric<WebCore::PageIdentifierType, WTF::ObjectIdentifierMainThreadAccessTraits<unsigned long long>, unsigned long long, (WTF::SupportsObjectIdentifierNullState)0>, WebKit::WebPageCreationParameters&&) 7 0x12a09ff60 WebKit::WebPage::create(WTF::ObjectIdentifierGeneric<WebCore::PageIdentifierType, WTF::ObjectIdentifierMainThreadAccessTraits<unsigned long long>, unsigned long long, (WTF::SupportsObjectIdentifierNullState)0>, WebKit::WebPageCreationParameters&&) 8 0x1291a74f0 WebKit::WebProcess::createWebPage(WTF::ObjectIdentifierGeneric<WebCore::PageIdentifierType, WTF::ObjectIdentifierMainThreadAccessTraits<unsigned long long>, unsigned long long, (WTF::SupportsObjectIdentifierNullState)0>, WebKit::WebPageCreationParameters&&) 9 0x12a502f80 auto void IPC::callMemberFunction<WebKit::WebProcess, WebKit::WebProcess, void (WTF::ObjectIdentifierGeneric<WebCore::PageIdentifierType, WTF::ObjectIdentifierMainThreadAccessTraits<unsigned long long>, unsigned long long, (WTF::SupportsObjectIdentifierNullState)0>, WebKit::WebPageCreationParameters&&), std::__1::tuple<WTF::ObjectIdentifierGeneric<WebCore::PageIdentifierType, WTF::ObjectIdentifierMainThreadAccessTraits<unsigned long long>, unsigned long long, (WTF::SupportsObjectIdentifierNullState)0>, WebKit::WebPageCreationParameters>>(WebKit::WebProcess*, void (WebKit::WebProcess::*)(WTF::ObjectIdentifierGeneric<WebCore::PageIdentifierType, WTF::ObjectIdentifierMainThreadAccessTraits<unsigned long long>, unsigned long long, (WTF::SupportsObjectIdentifierNullState)0>, WebKit::WebPageCreationParameters&&), std::__1::tuple<WTF::ObjectIdentifierGeneric<WebCore::PageIdentifierType, WTF::ObjectIdentifierMainThreadAccessTraits<unsigned long long>, unsigned long long, (WTF::SupportsObjectIdentifierNullState)0>, Test result link: https://ews-build.webkit.org/#/builders/62/builds/17729 History: https://results.webkit.org/?suite=layout-tests&test=http%2Ftests%2Fsite-isolation%2Fdraw-after-cross-origin-navigation-between-two-remote-frames.html&style=debug
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2024-10-08 14:23:40 PDT
<rdar://problem/137537468>
EWS
Comment 2 2024-10-08 16:41:24 PDT
Test gardening commit 284862@main (9a89492064c6): <https://commits.webkit.org/284862@main> Reviewed commits have been landed. Closing PR #34870 and removing active labels.
Charlie Wolfe
Comment 3 2024-10-21 15:25:13 PDT
Pull request: https://github.com/WebKit/WebKit/pull/35547
EWS
Comment 4 2024-10-21 15:31:51 PDT
Committed 285536@main (787757f6a233): <https://commits.webkit.org/285536@main> Reviewed commits have been landed. Closing PR #35547 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.