Bug 281062 – [FFC] Fix imported/w3c/web-platform-tests/css/css-flexbox/flex-factor-less-than-one.html

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[zalan]

ssia

[zalan]

Created attachment 472860 [details]
[fast-cq]Patch

[Antti Koivisto]

Comment on attachment 472860 [details]
[fast-cq]Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=472860&action=review

> COMMIT_MESSAGE:14
> +Implement 9.7.5.b Calculate the remaining free space
> +
> +"Calculate the remaining free space as for initial free space, above.
> +If the sum of the unfrozen flex items' flex factors is less than one,
> +multiply the initial free space by this sum.
> +If the magnitude of this value is less than the magnitude of the remaining free space,
> +use this as the remaining free space."
> +
> +https://drafts.csswg.org/css-flexbox-1/#resolve-flexible-lengths

Might be good to have some of these references as code comments too.

[zalan]

(In reply to Antti Koivisto from comment #2)
> Comment on attachment 472860 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=472860&action=review
> 
> > COMMIT_MESSAGE:14
> > +Implement 9.7.5.b Calculate the remaining free space
> > +
> > +"Calculate the remaining free space as for initial free space, above.
> > +If the sum of the unfrozen flex items' flex factors is less than one,
> > +multiply the initial free space by this sum.
> > +If the magnitude of this value is less than the magnitude of the remaining free space,
> > +use this as the remaining free space."
> > +
> > +https://drafts.csswg.org/css-flexbox-1/#resolve-flexible-lengths
> 
> Might be good to have some of these references as code comments too.
It is actually in the code just a few lines above where the lambda starts.

[EWS]

Committed 284852@main (7c396b74150e): <https://commits.webkit.org/284852@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 472860 [details].

[Radar WebKit Bug Importer]

<rdar://problem/137540977>