RESOLVED FIXED 281050
REGRESSION(268543@main) [GTK][WPE] Build broken with ENABLE_NOTIFICATIONS=OFF 
https://bugs.webkit.org/show_bug.cgi?id=281050
Summary REGRESSION(268543@main) [GTK][WPE] Build broken with ENABLE_NOTIFICATIONS=OFF
Miguel Gomez
Reported 2024-10-08 05:31:53 PDT
ENABLE_NOTIFICATION_EVENT is being enabled even when ENABLE_NOTIFICATIONS is disabled. This comes from 268543@main, where PlatformEnable.h was divided into platform specific files and PlatformEnableGLib.h was added. In that file, ENABLE_NOTIFICATION_EVENT should be enabled only if ENABLE_NOTIFICATIONS was enabled, but that check is missing. Due to that, a later check in PlatformEnable.h that ensures that ENABLE_NOTIFICATION_EVENT is enabled only if ENABLE_NOTIFICATIONS fails and breaks the build.
Attachments
Add attachment proposed patch, testcase, etc.
Miguel Gomez
Comment 1 2024-10-08 05:47:29 PDT
Pull request: https://github.com/WebKit/WebKit/pull/34836
EWS
Comment 2 2024-10-08 06:47:13 PDT
Committed 284824@main (428fbe5e5aeb): <https://commits.webkit.org/284824@main> Reviewed commits have been landed. Closing PR #34836 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.