WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
281047
[GTK][WPE] Build broken with ENABLE_FULLSCREEN_API=OFF
https://bugs.webkit.org/show_bug.cgi?id=281047
Summary
[GTK][WPE] Build broken with ENABLE_FULLSCREEN_API=OFF
Miguel Gomez
Reported
2024-10-08 03:51:33 PDT
There are 2 errors here: - The default value for the enable-fullscreen setting can only be accessed through the FEATURE_DEFAULT macro if ENABLE_FULLSCREEN_API is enabled. - ViewPlatform::toplevelStateChanged should not check fullscreen state changes if ENABLE_FULLSCREEN_API is not enabled.
Attachments
Add attachment
proposed patch, testcase, etc.
Miguel Gomez
Comment 1
2024-10-08 03:55:57 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/34832
EWS
Comment 2
2024-10-08 06:45:17 PDT
Committed
284823@main
(cb4ac1ae97ba): <
https://commits.webkit.org/284823@main
> Reviewed commits have been landed. Closing PR #34832 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug