RESOLVED FIXED 281000
[WPE][GTK] Building 2.46.1 is broken with ENABLE_VIDEO=OFF 
https://bugs.webkit.org/show_bug.cgi?id=281000
Summary [WPE][GTK] Building 2.46.1 is broken with ENABLE_VIDEO=OFF
Adrian Perez
Reported 2024-10-07 14:06:13 PDT
In file included from /home/aperez/buildroot/output-rpi4-wpe/build/wpewebkit-2.46.1/Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUCommandBuffer.h:28, from /home/aperez/buildroot/output-rpi4-wpe/build/wpewebkit-2.46.1/Source/WebCore/Modules/WebGPU/GPUCommandBuffer.h:28, from /home/aperez/buildroot/output-rpi4-wpe/build/wpewebkit-2.46.1/Source/WebCore/Modules/WebGPU/GPUCommandBuffer.cpp:27, from /home/aperez/buildroot/output-rpi4-wpe/build/wpewebkit-2.46.1/WebCore/DerivedSources/unified-sources/UnifiedSource-f8afad56-2.cpp:1: /home/aperez/buildroot/output-rpi4-wpe/build/wpewebkit-2.46.1/WTF/Headers/wtf/Ref.h: In instantiation of ‘static void WTF::DefaultRefDerefTraits< <template-parameter-1-1> >::derefIfNotNull(T*) [with T = WebCore::HTMLVideoElement]’: /home/aperez/buildroot/output-rpi4-wpe/build/wpewebkit-2.46.1/WTF/Headers/wtf/RefPtr.h:60:61: required from ‘WTF::RefPtr<T, <template-parameter-1-2>, <template-parameter-1-3> >::~RefPtr() [with T = WebCore::HTMLVideoElement; _PtrTraits = WTF::RawPtrTraits<WebCore::HTMLVideoElement>; _RefDerefTraits = WTF::DefaultRefDerefTraits<WebCore::HTMLVideoElement>]’ /home/aperez/buildroot/output-rpi4-wpe/per-package/wpewebkit/host/arm-buildroot-linux-gnueabihf/include/c++/13.3.0/bits/stl_pair.h:187:12: required from here /home/aperez/buildroot/output-rpi4-wpe/build/wpewebkit-2.46.1/WTF/Headers/wtf/Ref.h:62:18: error: invalid use of incomplete type ‘class WebCore::HTMLVideoElement’ 62 | ptr->deref(); | ~~~~~^~~~~ In file included from /home/aperez/buildroot/output-rpi4-wpe/build/wpewebkit-2.46.1/Source/WebCore/html/HTMLCanvasElement.h:32, from /home/aperez/buildroot/output-rpi4-wpe/build/wpewebkit-2.46.1/Source/WebCore/Modules/WebGPU/GPUImageCopyExternalImage.h:29, from /home/aperez/buildroot/output-rpi4-wpe/build/wpewebkit-2.46.1/Source/WebCore/Modules/WebGPU/GPUQueue.h:31, from /home/aperez/buildroot/output-rpi4-wpe/build/wpewebkit-2.46.1/Source/WebCore/Modules/WebGPU/GPUDevice.h:36, from /home/aperez/buildroot/output-rpi4-wpe/build/wpewebkit-2.46.1/Source/WebCore/Modules/WebGPU/GPUDevice.cpp:27, from /home/aperez/buildroot/output-rpi4-wpe/build/wpewebkit-2.46.1/WebCore/DerivedSources/unified-sources/UnifiedSource-f8afad56-2.cpp:8: /home/aperez/buildroot/output-rpi4-wpe/build/wpewebkit-2.46.1/Source/WebCore/dom/Document.h:164:7: note: forward declaration of ‘class WebCore::HTMLVideoElement’ 164 | class HTMLVideoElement; | ^~~~~~~~~~~~~~~~
Attachments
Add attachment proposed patch, testcase, etc.
Adrian Perez
Comment 1 2024-10-07 14:10:35 PDT
It seems the actual issue is that the build with ENABLE_VIDEO=OFF is broken in the 2.46.x branch (at least).
Adrian Perez
Comment 2 2024-10-15 10:02:14 PDT
Should be fixed after the following backports were merged in the webkitglib/2.46 branch: - 282416.204@webkitglib/2.46 - 282416.205@webkitglib/2.46 - 282416.206@webkitglib/2.46 Note that it's still needed to use ENABLE_WEB_AUDIO=OFF and ENABLE_WEB_CODECS=OFF to disable multimedia support and avoid the GStreamer dependency (as it has been the case for years).
Note You need to log in before you can comment on or make changes to this bug.