RESOLVED FIXED280975
[libpas] Centralize toggles for libpas debug logging 
https://bugs.webkit.org/show_bug.cgi?id=280975
Summary [libpas] Centralize toggles for libpas debug logging
Marcus Plutowski
Reported 2024-10-07 08:11:34 PDT
rdar://137427586 Currently various functions within libpas have little `if (verbose) PAS_LOG(...)` blocks which are quite helpful for understanding what's going on underneath the hood. However, the 'verbose' flags that these functions use are defined inside each function that uses them, so turning groups of them on and off is very annoying. We can keep the existing 'verbose' variables, but it'd be helpful to have a libpas-wide macro (PAS_LOG_LEVEL or PAS_SHOULD_LOG) that would make it easier to turn on and off large groups of these prints at once.
Attachments
Add attachment proposed patch, testcase, etc.
Marcus Plutowski
Comment 1 2024-10-07 08:48:46 PDT
Pull request: https://github.com/WebKit/WebKit/pull/34775
EWS
Comment 2 2024-10-17 14:10:04 PDT
Committed 285358@main (dde95ad41f4e): <https://commits.webkit.org/285358@main> Reviewed commits have been landed. Closing PR #34775 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.