WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
280917
Suppress smart pointer warnings on impl objects in auto-generated JS bindings code
https://bugs.webkit.org/show_bug.cgi?id=280917
Summary
Suppress smart pointer warnings on impl objects in auto-generated JS bindings...
Ryosuke Niwa
Reported
2024-10-04 16:23:26 PDT
Since JS wrapper holds a strong reference to the impl object and JS wrappers are kept alive for the duration of C++ function invocation, it's safe to call into functions without having an aexplicit Ref/RefPtr to the same object in stack.
Attachments
Add attachment
proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1
2024-10-04 16:27:32 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/34725
EWS
Comment 2
2024-10-04 22:41:02 PDT
Committed
284725@main
(505f84a26e79): <
https://commits.webkit.org/284725@main
> Reviewed commits have been landed. Closing PR #34725 and removing active labels.
Radar WebKit Bug Importer
Comment 3
2024-10-04 22:42:15 PDT
<
rdar://problem/137328943
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug