Bug 28089 - [V8] Renamed all NPN_ functions to _NPN_ to match JSC and make them "private"
Summary: [V8] Renamed all NPN_ functions to _NPN_ to match JSC and make them "private"
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Jeremy Orlow
Depends on:
Reported: 2009-08-07 17:25 PDT by Jeremy Orlow
Modified: 2009-08-10 21:17 PDT (History)
4 users (show)

See Also:

Patch v1 (20.88 KB, patch)
2009-08-07 17:31 PDT, Jeremy Orlow
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Orlow 2009-08-07 17:25:19 PDT
[V8] Renamed all NPN_ functions to _NPN_ to match JSC and make them "private".
Comment 1 Jeremy Orlow 2009-08-07 17:31:30 PDT
Created attachment 34346 [details]
Patch v1
Comment 2 Eric Seidel (no email) 2009-08-07 20:53:33 PDT
Comment on attachment 34346 [details]
Patch v1

I'm not sure why we have this prefix.  But sounds fine to me.
Comment 3 Eric Seidel (no email) 2009-08-07 20:53:48 PDT
cc'd anders so he sees this go by.
Comment 4 David Levin 2009-08-09 22:56:06 PDT
In WebKit style if a parameter name doesn't add information in a function declaration, then the name isn't included.  For example "identifier" shouldn't be included here:
   bool _NPN_IdentifierIsString(NPIdentifier identifier);

Feel free to clean these up on landing.
Comment 5 Jeremy Orlow 2009-08-10 21:17:50 PDT
Sending        WebCore/ChangeLog
Sending        WebCore/bindings/v8/NPV8Object.cpp
Sending        WebCore/bindings/v8/ScriptController.cpp
Sending        WebCore/bindings/v8/V8NPObject.cpp
Sending        WebCore/bindings/v8/V8NPUtils.cpp
Sending        WebCore/bindings/v8/npruntime.cpp
Sending        WebCore/bindings/v8/npruntime_impl.h
Transmitting file data .......
Committed revision 47021.