RESOLVED FIXED 28089
[V8] Renamed all NPN_ functions to _NPN_ to match JSC and make them "private" 
https://bugs.webkit.org/show_bug.cgi?id=28089
Summary [V8] Renamed all NPN_ functions to _NPN_ to match JSC and make them "private"
Jeremy Orlow
Reported 2009-08-07 17:25:19 PDT
[V8] Renamed all NPN_ functions to _NPN_ to match JSC and make them "private".
Attachments
Patch v1 (20.88 KB, patch)
2009-08-07 17:31 PDT, Jeremy Orlow 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jeremy Orlow
Comment 1 2009-08-07 17:31:30 PDT
Created attachment 34346 [details] Patch v1
Eric Seidel (no email)
Comment 2 2009-08-07 20:53:33 PDT
Comment on attachment 34346 [details] Patch v1 I'm not sure why we have this prefix. But sounds fine to me.
Eric Seidel (no email)
Comment 3 2009-08-07 20:53:48 PDT
cc'd anders so he sees this go by.
David Levin
Comment 4 2009-08-09 22:56:06 PDT
In WebKit style if a parameter name doesn't add information in a function declaration, then the name isn't included. For example "identifier" shouldn't be included here: bool _NPN_IdentifierIsString(NPIdentifier identifier); Feel free to clean these up on landing.
Jeremy Orlow
Comment 5 2009-08-10 21:17:50 PDT
Sending WebCore/ChangeLog Sending WebCore/bindings/v8/NPV8Object.cpp Sending WebCore/bindings/v8/ScriptController.cpp Sending WebCore/bindings/v8/V8NPObject.cpp Sending WebCore/bindings/v8/V8NPUtils.cpp Sending WebCore/bindings/v8/npruntime.cpp Sending WebCore/bindings/v8/npruntime_impl.h Transmitting file data ....... Committed revision 47021. http://trac.webkit.org/changeset/47021
Note You need to log in before you can comment on or make changes to this bug.