Bug 28087 - [Chromium] Mods for a chrome specific impl of ApplicationCacheHost
Summary: [Chromium] Mods for a chrome specific impl of ApplicationCacheHost
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Jeremy Orlow
Depends on:
Reported: 2009-08-07 16:54 PDT by Michael Nordman
Modified: 2009-08-10 20:50 PDT (History)
2 users (show)

See Also:

use PLATFORM(CHROMIUM) to segregate the private section (4.91 KB, patch)
2009-08-07 17:53 PDT, Michael Nordman
fishd: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Nordman 2009-08-07 16:54:05 PDT
The private section of class ApplicationCacheHost currently contains members  that aren't applicable to chrome's impl, and is lacking other members that are needed. We need to carve out some space in this class to share the public part of this interface and not step on each other in the private section.
Comment 1 Michael Nordman 2009-08-07 17:53:30 PDT
Created attachment 34348 [details]
use PLATFORM(CHROMIUM) to segregate the private section
Comment 2 Michael Nordman 2009-08-09 09:48:56 PDT
Fyi: I've intentionally  chosen to use the PLATFORM flag here to help clarify what parts of the appcache system are actually in the CHROMIUM port. The majority of the appcache directory is not, a few files are...

* ApplicationCacheHost.h
* DOMApplicationCache.idl .h .cpp

Using the PLATFORM() flag in this .h file is reflective of that, and while it may not make it crystal clear what classes/files are relevant to CHROMIUM, it does provide big clues that ApplicationCacheGroup and familiy don't apply.

My thinking is that having this reflected in the .h file helps with maintainability.

I'd be willing to shuffle some more deck chairs around to create a ApplicationCacheHostInternal class that inter-operates with ApplicationCacheGroup and family (and removes the PLATFORM flag), but for the reason stated above, I don't think that would be an improvement.
Comment 3 Jeremy Orlow 2009-08-10 20:34:10 PDT
Will land by hand in a sec.
Comment 4 Jeremy Orlow 2009-08-10 20:50:08 PDT
Sending        WebCore/ChangeLog
Sending        WebCore/loader/appcache/ApplicationCacheHost.cpp
Sending        WebCore/loader/appcache/ApplicationCacheHost.h
Sending        WebCore/page/DOMWindow.cpp
Transmitting file data ....
Committed revision 47018.