Bug 28081 – <video> and <audio> controller should be accessible

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Eric Carlson]

Built-in <audio> and <video> controls do not work well with accessibility: controls are not in a logic tab order, all buttons names are reported as "button", the timeline slider values are reported as percentages, etc.

[Eric Carlson]

Created attachment 34335 [details]
proposed patch

[Eric Carlson]

<rdar://7065736 >

[Eric Carlson]

http://trac.webkit.org/changeset/47110

[Kenneth Rohde Christiansen]

This patch seem to have broken the Qt build:

failed
123 test cases (2%) had incorrect layout
3031 test cases (58%) crashed

[Eric Seidel (no email)]

Comment on attachment 34335 [details]
proposed patch

Was rolled out in:
http://trac.webkit.org/changeset/47140

failing tests were skipped in:
http://trac.webkit.org/changeset/47128

[Eric Carlson]

Created attachment 38374 [details]
revised patch

This is a minor rework of the patch reviewed last week. New this time are updated layout test results for Leopard and Windows, and some gtk localized strings I missed last time.

[Oliver Hunt]

Comment on attachment 38374 [details]
revised patch


> +String AccessibilityMediaTimeline::valueDescription() const
> +{
> +    float time = static_cast<HTMLInputElement*>(m_renderer->node())->value().toFloat();
What is the guarantee that our renderer is an input element?


>  MediaControlMuteButtonElement::MediaControlMuteButtonElement(Document* document, HTMLMediaElement* element)
> -    : MediaControlInputElement(document, MEDIA_CONTROLS_MUTE_BUTTON, "button", element, element->muted() ? MediaUnMuteButton : MediaMuteButton)
> +    :: MediaControlInputElement(document, MEDIA_CONTROLS_MUTE_BUTTON, "button", element)
>  {
>  }
This change looks bogus (:: vs :)

r+ assuming you fix the bogosity and explain why the above cast is safe

[Eric Carlson]

> > +String AccessibilityMediaTimeline::valueDescription() const
> > +{
> > +    float time = static_cast<HTMLInputElement*>(m_renderer->node())->value().toFloat();
> 
> What is the guarantee that our renderer is an input element?

  AccessibilityMediaTimeline is only created if the node is an input element, but I will add an ASSERT() in any case.


> >  MediaControlMuteButtonElement::MediaControlMuteButtonElement(Document* document, HTMLMediaElement* element)
> > -    : MediaControlInputElement(document, MEDIA_CONTROLS_MUTE_BUTTON, "button", element, element->muted() ? MediaUnMuteButton : MediaMuteButton)
> > +    :: MediaControlInputElement(document, MEDIA_CONTROLS_MUTE_BUTTON, "button", element)
> >  {
> >  }
>
> This change looks bogus (:: vs :)

Indeed!

[Eric Carlson]

http://trac.webkit.org/changeset/47763