Bug 28077 - [Qt] DumpRenderTree behaves incorrectly when generating test results
Summary: [Qt] DumpRenderTree behaves incorrectly when generating test results
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-07 11:40 PDT by George Wright
Modified: 2009-08-07 17:53 PDT (History)
1 user (show)

See Also:

Attachments
Fix for dumping PNGs in DRT (1.38 KB, patch)
2009-08-07 11:44 PDT, George Wright 		eric: review-
Details | Formatted Diff | Diff
Amended changelog (1.42 KB, patch)
2009-08-07 11:52 PDT, George Wright 		manyoso: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description George Wright 2009-08-07 11:40:47 PDT 
DumpRenderTree for the Qt port currently only dumps the PNG image data if an expected hash is provided on the commandline. When generating test results, the expected hash is not provided. The Mac port's behaviour differs in that it always dumps the PNG image data unless the expected hash and actual hash match.
Comment 1 George Wright 2009-08-07 11:44:13 PDT 
Created attachment 34304 [details]
Fix for dumping PNGs in DRT

Proposed fix.
Comment 2 Eric Seidel (no email) 2009-08-07 11:47:25 PDT 
Comment on attachment 34304 [details]
Fix for dumping PNGs in DRT

Specifically, not to dump the images if the hashes match.  Please update the ChangeLog to be more clear.

Otherwise the change looks great!
Comment 3 George Wright 2009-08-07 11:52:28 PDT 
Created attachment 34308 [details]
Amended changelog

ChangeLog made more verbose
Comment 4 Adam Barth 2009-08-07 17:53:28 PDT 
This patch appears to have already been landed.