Bug 28074 - V8 bindings for DOMApplicationCache
Summary: V8 bindings for DOMApplicationCache
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-07 10:48 PDT by Michael Nordman
Modified: 2009-08-07 15:09 PDT (History)
4 users (show)

See Also:


Attachments
v8bindings (14.69 KB, patch)
2009-08-07 10:59 PDT, Michael Nordman
dglazkov: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Nordman 2009-08-07 10:48:48 PDT
We need to add some bindings for the window.applicationCache attribute and the API available on the returned object.
Comment 1 Michael Nordman 2009-08-07 10:59:52 PDT
Created attachment 34295 [details]
v8bindings
Comment 2 Eric Seidel (no email) 2009-08-07 14:32:00 PDT
Adam Barth or Dglazkov are your peoples.
Comment 3 Dimitri Glazkov (Google) 2009-08-07 14:44:04 PDT
Comment on attachment 34295 [details]
v8bindings

> -// A JS object of type EventTarget can only be the following possible types:
> -// 1) EventTargetNode; 2) DOMWindow 3) XMLHttpRequest; 4) MessagePort;
> -// 5) XMLHttpRequestUpload
> -// check EventTarget.h for new type conversion methods
> +// A JS object of type EventTarget is limited to a small number of possible classes.
> +// Check EventTarget.h for new type conversion methods

Heh, good call on this one :)

r=me.
Comment 4 Dimitri Glazkov (Google) 2009-08-07 15:09:32 PDT
Landed as http://trac.webkit.org/changeset/46917.