Bug 28066 - Avoid using TCmalloc in DumpRenderTree
Summary: Avoid using TCmalloc in DumpRenderTree
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 27879
  Show dependency tree / graph
 
Reported: 2009-08-07 04:47 PDT by Zoltan Horvath
Modified: 2009-08-10 05:48 PDT (History)
0 users

See Also:

Attachments
proposed patch (2.84 KB, patch)
2009-08-07 04:51 PDT, Zoltan Horvath 		darin: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Horvath 2009-08-07 04:47:09 PDT 
Since Noncopyable'll be inherited from FastAllocBase (and RefCounted has been inherited from Noncopyable), in case of DRT classes using of TCmalloc must be avoided.
This change repairs the GTK+'s DRT build fail as well (in case of inheriting Noncopyable from FastAllocBase bug #27879).
Comment 1 Zoltan Horvath 2009-08-07 04:51:31 PDT 
Created attachment 34266 [details]
proposed patch
Comment 2 Darin Adler 2009-08-07 07:13:47 PDT 
Comment on attachment 34266 [details]
proposed patch

This makes the class name RefCountedCustomAllocated seem pretty bad. After all, there's no desire to "custom allocate" here.

I think we should consider doing this with the preprocessor instead of different class names when we're talking about an entirely different binary like DumpRenderTree, since USE_SYSTEM_MALLOC is already set. Can we investigate that instead?
Comment 3 Mark Rowe (bdash) 2009-08-07 16:55:54 PDT 
Why are we trying to avoid using FastMalloc from DumpRenderTree?  DRT's config.h explicitly includes FastMalloc.h so that uses of operator new will go via fastMalloc.
Comment 4 Zoltan Horvath 2009-08-10 05:46:17 PDT 
GTK+ guys solved the build error in r46944 (http://trac.webkit.org/changeset/46944/trunk/WebKitTools/GNUmakefile.am) which caused by Noncopyable's change, so this patch is obsolete.