WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
28055
LayoutTests/editing/execCommand/boldSelection.html must be a dumpAsText test
https://bugs.webkit.org/show_bug.cgi?id=28055
Summary
LayoutTests/editing/execCommand/boldSelection.html must be a dumpAsText test
Ryosuke Niwa
Reported
2009-08-06 13:47:33 PDT
LayoutTests/editing/styles/boldSelection.html need not be a pixel test because we do not need to test the rendering. But we must check whether we are adding b or style span. For this reason, this test must be converted to a dumpAsText. Furthermore, this test needs description on what it tests.
Attachments
converts boldSelection.html to a dumpAsText test and adds description.
(38.92 KB, patch)
2009-08-06 14:12 PDT
,
Ryosuke Niwa
eric
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1
2009-08-06 13:51:41 PDT
The test is under editing/execCommand instead of editing/style.
Ryosuke Niwa
Comment 2
2009-08-06 14:12:33 PDT
Created
attachment 34228
[details]
converts boldSelection.html to a dumpAsText test and adds description.
Eric Seidel (no email)
Comment 3
2009-08-06 14:25:08 PDT
Comment on
attachment 34228
[details]
converts boldSelection.html to a dumpAsText test and adds description. Looks great! Thanks for splitting this out! Please fix the douplicate when landing: var selection = window.getSelection(); 22 var selection = window.getSelection();
Ryosuke Niwa
Comment 4
2009-08-06 14:56:44 PDT
Landed in
http://trac.webkit.org/changeset/46860
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug