Bug 28051 - [WINCE] make JPEGImageDecoder.cpp build for WINCE
Summary: [WINCE] make JPEGImageDecoder.cpp build for WINCE
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
Depends on:
Blocks: 23154
  Show dependency treegraph
Reported: 2009-08-06 11:14 PDT by Joe Mason
Modified: 2009-08-06 22:10 PDT (History)
3 users (show)

See Also:

patch to JPEGImageDecoder.cpp (1.50 KB, patch)
2009-08-06 11:17 PDT, Joe Mason
abarth: commit-queue+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joe Mason 2009-08-06 11:14:31 PDT
JPEGImageDecoder.cpp gives a compile error on WinCE: "redefining INT32"
Comment 1 Joe Mason 2009-08-06 11:17:34 PDT
Created attachment 34213 [details]
patch to JPEGImageDecoder.cpp
Comment 2 Eric Seidel (no email) 2009-08-06 14:49:20 PDT
Comment on attachment 34213 [details]
patch to JPEGImageDecoder.cpp

Seems OK.  the copyright line seems like a strange place.  Also, you're releasing this in 2009, so I don't see how you can claim copyright 2007. :)  Not that it matters...
Comment 3 Joe Mason 2009-08-06 15:32:51 PDT
Well, because we wrote it in 2007...  (Also, this isn't the first release - the source has been available from our web site ever since we released the first binaries.  We just missed this in the first batch of patches we submitted.)
Comment 4 Adam Barth 2009-08-06 22:09:59 PDT
Comment on attachment 34213 [details]
patch to JPEGImageDecoder.cpp

Clearing review flag on attachment: 34213

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp
Committed r46884
	M	WebKit/wx/ChangeLog
	A	WebKit/wx/bindings/python/wscript
r46883 = 3a864c52b9da120e2992fe77e4e2b92b32accdd7 (trunk)
	M	WebCore/ChangeLog
	M	WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp
r46884 = 8fe9f42b854e18a739f8c4fa63afa00e9b18aa0c (trunk)
First, rewinding head to replay your work on top of it...
Nothing to do.
Comment 5 Adam Barth 2009-08-06 22:10:04 PDT
All reviewed patches have been landed.  Closing bug.