RESOLVED FIXED 28048
Place More WinCairo Settings in vsprop files 
https://bugs.webkit.org/show_bug.cgi?id=28048
Summary Place More WinCairo Settings in vsprop files
Brent Fulgham
Reported 2009-08-06 10:31:18 PDT
To ease maintenance of the WinCairo port, move several library and compiler flag settings into specific *.vsprops files.
Attachments
Move some settings into WinCairo/cURL vsprops files. (9.72 KB, patch)
2009-08-10 10:57 PDT, Brent Fulgham 		aroben: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2009-08-10 10:57:52 PDT
Created attachment 34483 [details] Move some settings into WinCairo/cURL vsprops files.
Adam Roben (:aroben)
Comment 2 2009-08-10 11:01:53 PDT
Comment on attachment 34483 [details] Move some settings into WinCairo/cURL vsprops files. > + * WebKit.vcproj/WebKit.vcproj: Add vsprops settings, and remove > + manual flags and library dependencies for WinCairo port. I think a little more detail would be preferable here, given the difficulty of reading .vcproj diffs. > - ForcedIncludeFiles="WebKitPrefix.h" > DisableSpecificWarnings="4819" > + ForcedIncludeFiles="WebKitPrefix.h" I'm surprised by this change. r=me
Brent Fulgham
Comment 3 2009-08-10 11:04:14 PDT
(In reply to comment #2) > (From update of attachment 34483 [details]) > > + * WebKit.vcproj/WebKit.vcproj: Add vsprops settings, and remove > > + manual flags and library dependencies for WinCairo port. > I think a little more detail would be preferable here, given the difficulty of > reading .vcproj diffs. > > - ForcedIncludeFiles="WebKitPrefix.h" > > DisableSpecificWarnings="4819" > > + ForcedIncludeFiles="WebKitPrefix.h" > I'm surprised by this change. > r=me I think this is just internal visual studio foo. I'll see if I can avoid this change being committed by modifying the vcproj file manually.
Brent Fulgham
Comment 4 2009-08-10 11:23:10 PDT
Landed in http://trac.webkit.org/changeset/46990
Note You need to log in before you can comment on or make changes to this bug.