Bug 28048 - Place More WinCairo Settings in vsprop files
Summary: Place More WinCairo Settings in vsprop files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-06 10:31 PDT by Brent Fulgham
Modified: 2009-08-10 11:23 PDT (History)
0 users

See Also:


Attachments
Move some settings into WinCairo/cURL vsprops files. (9.72 KB, patch)
2009-08-10 10:57 PDT, Brent Fulgham
aroben: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2009-08-06 10:31:18 PDT
To ease maintenance of the WinCairo port, move several library and compiler flag settings into specific *.vsprops files.
Comment 1 Brent Fulgham 2009-08-10 10:57:52 PDT
Created attachment 34483 [details]
Move some settings into WinCairo/cURL vsprops files.
Comment 2 Adam Roben (:aroben) 2009-08-10 11:01:53 PDT
Comment on attachment 34483 [details]
Move some settings into WinCairo/cURL vsprops files.

> +        * WebKit.vcproj/WebKit.vcproj: Add vsprops settings, and remove
> +          manual flags and library dependencies for WinCairo port.

I think a little more detail would be preferable here, given the difficulty of reading .vcproj diffs.

> -				ForcedIncludeFiles="WebKitPrefix.h"
>  				DisableSpecificWarnings="4819"
> +				ForcedIncludeFiles="WebKitPrefix.h"

I'm surprised by this change.

r=me
Comment 3 Brent Fulgham 2009-08-10 11:04:14 PDT
(In reply to comment #2)
> (From update of attachment 34483 [details])
> > +        * WebKit.vcproj/WebKit.vcproj: Add vsprops settings, and remove
> > +          manual flags and library dependencies for WinCairo port.
> I think a little more detail would be preferable here, given the difficulty of
> reading .vcproj diffs.
> > -				ForcedIncludeFiles="WebKitPrefix.h"
> >  				DisableSpecificWarnings="4819"
> > +				ForcedIncludeFiles="WebKitPrefix.h"
> I'm surprised by this change.
> r=me

I think this is just internal visual studio foo.  I'll see if I can avoid this change being committed by modifying the vcproj file manually.
Comment 4 Brent Fulgham 2009-08-10 11:23:10 PDT
Landed in http://trac.webkit.org/changeset/46990