Bug 28042 - TODO: gobject bindings will need #ifdef DATAGRID support
Summary: TODO: gobject bindings will need #ifdef DATAGRID support
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
Depends on:
Blocks: 16401
  Show dependency treegraph
Reported: 2009-08-06 02:53 PDT by Luke Kenneth Casson Leighton
Modified: 2011-07-11 13:21 PDT (History)
1 user (show)

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Luke Kenneth Casson Leighton 2009-08-06 02:53:20 PDT
for background, see https://bugs.webkit.org/show_bug.cgi?id=27425

this is notes to whomever implements DATAGRID for the Gobject bindings.

a patch has been accepted which includes a FIXME workaround which disables attempts to use code which the CodeGeneratorGObject.pm does not create (GdomHTMLDataGridElement.cpp,h; GdomHTMLDataGridRowElement.cpp,h) which in turn rely on code which also does not exist (GdomDataGridDataSource.cpp,h).

WebCore/bindings/gdom/GdomDataGridDataSource.cpp,h will need to be created by copying cut/paste style WebCore/bindings/js/JSDataGridDataSource.cpp,h and also working out why there is a custom WebCore/bindings/js/JSCustomHTMLDataGridColumnElement.cpp, and whether that needs to be copied cut/paste style to create WebCore/bindings/gdom/GdomCustomHTMLDataGridColumnElement.cpp.

also it may be necessary to add a toGDOM function to WebCore/bindings/gdom/GDOMBinding.cpp for the DataGridDataSource base class.
Comment 1 Luke Kenneth Casson Leighton 2009-08-07 04:34:40 PDT
see also gdom.h which has #ifdef'd code for DATAGRID
Comment 2 Martin Robinson 2011-07-11 13:21:40 PDT
Not sure if this is valid any longer. Feel free to re-open if I'm wrong.