Bug 28033 – Win DRT is missing implementations for some resource load delegate callbacks

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Brady Eidson]

Win DRT is missing implementations for some resource load delegate callbacks.

Has been tracked in radar by <rdar://problem/7102793>

[Brady Eidson]

Created attachment 34191 [details]
didReceiveResponse (other missing ones can come later)

[Darin Adler]

Comment on attachment 34191 [details]
didReceiveResponse (other missing ones can come later)

Can't we use smart pointers for the BSTR?

r=me

[Brady Eidson]

I don't think we use any sort of BSTR smart pointer anywhere else in WinDRT - Do we have one available?  I know that - at least at one time - there wasn't one available.

Thanks for the review!

Sending        LayoutTests/ChangeLog
Sending        LayoutTests/platform/win/Skipped
Deleting       LayoutTests/platform/win/http/tests/security
Sending        WebKitTools/ChangeLog
Sending        WebKitTools/DumpRenderTree/win/ResourceLoadDelegate.cpp
Sending        WebKitTools/DumpRenderTree/win/ResourceLoadDelegate.h
Transmitting file data .....
Committed revision 46820.

[Brady Eidson]

Darin reviewed this in person.  Added 3 more missing methods, and removed a skipped test.

Sending        LayoutTests/ChangeLog
Sending        LayoutTests/platform/win/Skipped
Sending        WebKitTools/ChangeLog
Sending        WebKitTools/DumpRenderTree/win/FrameLoadDelegate.cpp
Sending        WebKitTools/DumpRenderTree/win/FrameLoadDelegate.h
Transmitting file data .....
Committed revision 46824.

Maybe we should leave this bugzilla open as there are still many missing delegate methods.  Maybe some other tests on the skipped list are related.

[Darin Fisher (:fishd, Google)]

Looks like this can be closed as FIXED.