Bug 28029 - Fix DOM Storage memory leak
Summary: Fix DOM Storage memory leak
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-05 15:16 PDT by Jeremy Orlow
Modified: 2009-08-05 15:48 PDT (History)
1 user (show)

See Also:

Attachments
Patch v1 (1.17 KB, patch)
2009-08-05 15:16 PDT, Jeremy Orlow 		no flags Details | Formatted Diff | Diff
Patch v1 (1.36 KB, patch)
2009-08-05 15:18 PDT, Jeremy Orlow 		fishd: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Orlow 2009-08-05 15:16:00 PDT 
Created attachment 34185 [details]
Patch v1

Forgot to use adoptRef in one place.  This caused the = operator to increment
the ref count when it should have just left it as is.  The result of this was
that StorageAreaImpl's were never being freed.
Comment 1 Jeremy Orlow 2009-08-05 15:18:11 PDT 
Created attachment 34187 [details]
Patch v1
Comment 2 Jeremy Orlow 2009-08-05 15:48:52 PDT 
Sending        WebCore/ChangeLog
Sending        WebCore/storage/StorageNamespaceImpl.cpp
Transmitting file data ..
Committed revision 46818.
http://trac.webkit.org/changeset/46818