RESOLVED FIXED Bug 280063
Regression (Safari 18.0): WordPress Classic Editor sidebar layout is broken (floats not clearing)
https://bugs.webkit.org/show_bug.cgi?id=280063
Summary Regression (Safari 18.0): WordPress Classic Editor sidebar layout is broken (...
zalan
Reported 2024-09-20 07:31:39 PDT
Demo link to run WP classic editor in your browser: https://playground.wordpress.net/?plugin=classic-editor&blueprint-url=https://wordpress.org/plugins/wp-json/plugins/v1/plugin/classic-editor/blueprint.json?rev=3122271 Reproduction steps: 1. Click Screen Options 2. Enable Custom Fields and Discussion In Safari 18 the new meta boxes are overlapping content on the right of the screen. In Safari 17 and other browsers they show below the post content as expected. <rdar://136362683>
Attachments
Test reduction (571 bytes, text/html)
2024-09-20 10:51 PDT, zalan
no flags
Patch (3.53 KB, patch)
2024-09-24 20:49 PDT, zalan
no flags
[fast-cq]Patch (18.21 KB, patch)
2024-09-25 09:25 PDT, zalan
no flags
Screenshot with the fix applied (728.39 KB, image/png)
2024-09-25 15:33 PDT, zalan
no flags
zalan
Comment 1 2024-09-20 10:51:01 PDT
Created attachment 472615 [details] Test reduction This is about negative horizontal margin on floats.
zalan
Comment 2 2024-09-24 20:49:00 PDT
zalan
Comment 3 2024-09-25 09:25:07 PDT
Created attachment 472678 [details] [fast-cq]Patch
EWS
Comment 4 2024-09-25 15:17:52 PDT
Committed 284247@main (dffa25228983): <https://commits.webkit.org/284247@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 472678 [details].
zalan
Comment 5 2024-09-25 15:33:33 PDT
Created attachment 472680 [details] Screenshot with the fix applied
EWS
Comment 6 2024-09-30 12:57:53 PDT
Committed 283286.156@safari-7620-branch (6aeec1ea5a94): <https://commits.webkit.org/283286.156@safari-7620-branch> Reviewed commits have been landed. Closing PR #1938 and removing active labels.
Eduard Comănici
Comment 7 2024-10-01 02:09:14 PDT
Do you guys mind me asking when this will ship? I rely on Safari and WordPress for my job and it is really annoying to use the "1 column" trick or other hacks. :(
peterwilsoncc
Comment 8 2024-10-01 16:05:00 PDT
An update of the classic editor has been shipped with a workaround, therefore the reproduction URL above will no longer show the regression. You can use this updated link to test on WordPress playground with a version of the classic editor without the fix: https://playground.wordpress.net/?plugin=https%3A%2F%2Fdownloads.wordpress.org%2Fplugin%2Fclassic-editor.1.6.3.zip&url=%2Fwp-admin%2Fpost-new.php The rest of the reproduction steps remain the same.
Eduard Comănici
Comment 9 2024-10-01 23:06:31 PDT
Peter, I see. However, my workflow does not involve the Classic Editor directly, but WooCommerce. Woo still uses a variant of the classic editor, not the plugin directly. :)
zalan
Comment 10 2024-10-24 06:15:57 PDT
*** Bug 281744 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.