Bug 28005 - Keypress should exit from pan scrolling mode
Summary: Keypress should exit from pan scrolling mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Brian Weinstein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-04 16:50 PDT by Brian Weinstein
Modified: 2009-08-04 22:21 PDT (History)
1 user (show)

See Also:

Attachments
Any Key Press (2.04 KB, patch)
2009-08-04 16:54 PDT, Brian Weinstein 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Weinstein 2009-08-04 16:50:06 PDT 
Pressing a key should exit the WebView from pan scrolling mode. This matches what IE and Opera do. We currently exit the WebView on escape, matching Firefox, but this could be hard to discover for users who may have middle clicked on accident.

<rdar://6591806>
Comment 1 Brian Weinstein 2009-08-04 16:54:46 PDT 
Created attachment 34100 [details]
Any Key Press
Comment 2 Adele Peterson 2009-08-04 17:16:12 PDT 
Comment on attachment 34100 [details]
Any Key Press

What do other browsers that support pan scrolling do?
Comment 3 Brian Weinstein 2009-08-04 17:19:49 PDT 
IE, Opera -> Exit pan scrolling on any keypress.
Firefox -> Exit only on escape
Safari, Chrome -> Exit only on escape - for now.

From the radar (Steve): This is kind of nasty, since if a user accidently middle clicks on a webpage, they can't type until they left click or hit escape.
Comment 4 Adele Peterson 2009-08-04 17:23:16 PDT 
Do IE and Opera also both cancel the pan scroll on keydown (instead of keyup)?
Comment 5 Brian Weinstein 2009-08-04 17:25:48 PDT 
Yes, and Firefox cancels on escape down.
Comment 6 Brian Weinstein 2009-08-04 22:21:53 PDT 
Clearing review flag - landed in http://trac.webkit.org/changeset/46793