Bug 28004 - [chromium] setting listeners on MessagePorts doesn't work in the worker process
Summary: [chromium] setting listeners on MessagePorts doesn't work in the worker process
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Dimitri Glazkov (Google)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-04 16:20 PDT by John Abd-El-Malek
Modified: 2009-08-06 10:46 PDT (History)
2 users (show)

See Also:

Attachments
Proposed patch (7.08 KB, patch)
2009-08-04 16:24 PDT, John Abd-El-Malek 		dglazkov: commit-queue+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Abd-El-Malek 2009-08-04 16:20:43 PDT 
Bindings need to be updated.
Comment 1 John Abd-El-Malek 2009-08-04 16:24:47 PDT 
Created attachment 34098 [details]
Proposed patch
Comment 2 Dimitri Glazkov (Google) 2009-08-05 12:54:59 PDT 
Comment on attachment 34098 [details]
Proposed patch

> +    return PassRefPtr<EventListener>();

return 0;

will work just fine, too.

Why are we duplicating these in *Custom files? The logic is the same. Can we possibly use a template or generate these?
If you're not up to mucking with this, can you file a bug about this?
Comment 3 Dimitri Glazkov (Google) 2009-08-05 12:55:43 PDT 
Assigned for landing.
Comment 4 Adam Barth 2009-08-05 20:05:46 PDT 
Comment on attachment 34098 [details]
Proposed patch

Clearing review flag on attachment: 34098

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/bindings/v8/WorkerContextExecutionProxy.cpp
	M	WebCore/bindings/v8/WorkerContextExecutionProxy.h
	M	WebCore/bindings/v8/custom/V8MessagePortCustom.cpp
Committed r46827
	M	WebCore/ChangeLog
	M	WebCore/bindings/v8/WorkerContextExecutionProxy.cpp
	M	WebCore/bindings/v8/WorkerContextExecutionProxy.h
	M	WebCore/bindings/v8/custom/V8MessagePortCustom.cpp
r46827 = 7956a160e452c6f261d5af9dc249b0854e5ed616 (trunk)
No changes between current HEAD and refs/remotes/trunk
Resetting to the latest refs/remotes/trunk
http://trac.webkit.org/changeset/46827
Comment 5 Adam Barth 2009-08-05 20:05:50 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 John Abd-El-Malek 2009-08-06 10:46:43 PDT 
Thanks for committing.

(In reply to comment #2)
> (From update of attachment 34098 [details])
> > +    return PassRefPtr<EventListener>();
> 
> return 0;
> 
> will work just fine, too.

ah, didn't know (I had just copied this section from the XHR custom bindings).

> 
> Why are we duplicating these in *Custom files? The logic is the same. Can we
> possibly use a template or generate these?

Yeah a template should work.

> If you're not up to mucking with this, can you file a bug about this?

Sure: https://bugs.webkit.org/show_bug.cgi?id=28049