Bug 27996 - [V8] Fix an assert in WebCoreStringResource that causes worker script evaluation failed.
Summary: [V8] Fix an assert in WebCoreStringResource that causes worker script evaluat...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Jian Li
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-04 14:24 PDT by Jian Li
Modified: 2009-08-04 15:52 PDT (History)
1 user (show)

See Also:


Attachments
Proposed Patch (2.40 KB, patch)
2009-08-04 14:29 PDT, Jian Li
levin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jian Li 2009-08-04 14:24:42 PDT
There is an assert in WebCoreStringResource that causes worker script evaluation failed. We should check for the same thread, instead of the main thread, in WebCoreStringResource.
Comment 1 Jian Li 2009-08-04 14:29:44 PDT
Created attachment 34087 [details]
Proposed Patch
Comment 2 David Levin 2009-08-04 14:41:59 PDT
Comment on attachment 34087 [details]
Proposed Patch

It would be nice to mention in the ChangeLog why this is needed.

Even thought Chromium's workers only use v8 in a single thread, they don't use it on the main thread.
Comment 3 Jian Li 2009-08-04 15:52:47 PDT
Committed as http://trac.webkit.org/changeset/46782.