Bug 27983 - Explicitly include limits.h header when using INT_MAX and INT_MIN
Summary: Explicitly include limits.h header when using INT_MAX and INT_MIN
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-04 07:45 PDT by Benjamin Meyer
Modified: 2009-08-04 07:59 PDT (History)
0 users

See Also:

Attachments
the patch (902 bytes, patch)
2009-08-04 07:46 PDT, Benjamin Meyer 		manyoso: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Meyer 2009-08-04 07:45:44 PDT 
Explicitly include limits.h header when using INT_MAX and INT_MIN to prevent build breakage when limits.h isn't included elsewhere by a port
Comment 1 Benjamin Meyer 2009-08-04 07:46:43 PDT 
Created attachment 34061 [details]
the patch
Comment 2 Adam Treat 2009-08-04 07:50:46 PDT 
Comment on attachment 34061 [details]
the patch

> From a82bc9d1cc1bb8aced54074bf3152c6f84ab560a Mon Sep 17 00:00:00 2001

>  #include <stdio.h>
> +#include <limits.h>
>  #include <wtf/Threading.h>

Change the order of includes as <limit.h> is alphabetically first before <stdio.h> and then r+.  You can change this when landing.