REGRESSION: bugzilla-tool land-diff double-spaces ChangeLogs An example of the badness: http://trac.webkit.org/changeset/46750 I have no clue what broke this. It must have been very recent, since I use land-diff to land all my changes...
I wonder if it could be this change: http://trac.webkit.org/changeset/46700/trunk/WebKitTools/Scripts/bugzilla-tool I kinda doubt it though.
It seems to be in the reviewer update code (not un-expected): bugzilla-tool --dry-run land-diff --no-build --reviewer="Bozo" reproduces the bug.
Ha! http://trac.webkit.org/changeset/46700/trunk/WebKitTools/Scripts/bugzilla-tool is the regression! Can you find it? ;)
Created attachment 34047 [details] Patch v1
Comment on attachment 34047 [details] Patch v1 Yay. Now if only we had better unit testing...
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKitTools/ChangeLog M WebKitTools/Scripts/bugzilla-tool Committed r46754 M WebKitTools/ChangeLog M WebKitTools/Scripts/bugzilla-tool r46754 = 3d81d05269c879e0aac096ceee849d47735726dd (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/46754
Comment on attachment 34047 [details] Patch v1 >+ The trailing comma (suppresses newlines) was lost in r46700. Heh...I thought the trailing comma was a typo. That's one of the weirdest language behaviors I've ever seen.
The comma is the tuple operator in python. So I assume print detects this by detecting if it's passed a list/tuple instead of a string. http://mail.python.org/pipermail/python-list/2005-July/332230.html talks more about this strange behavior.