RESOLVED FIXED 27969
bugzilla-tool has too many fatal errors 
https://bugs.webkit.org/show_bug.cgi?id=27969
Summary bugzilla-tool has too many fatal errors
Adam Barth
Reported 2009-08-03 23:30:10 PDT
A bunch of the calls to error should raise a ScriptError instead so the commit-queue can continue chugging along.
Attachments
Patch v1 (3.92 KB, patch)
2009-08-03 23:35 PDT, Adam Barth 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2009-08-03 23:35:48 PDT
Created attachment 34038 [details] Patch v1
Eric Seidel (no email)
Comment 2 2009-08-04 00:25:31 PDT
Comment on attachment 34038 [details] Patch v1 Looks fine. We might eventually go back to an error() method which just does the raise for us. I don't really like logging.py
Eric Seidel (no email)
Comment 3 2009-08-04 00:28:53 PDT
Comment on attachment 34038 [details] Patch v1 At least one of these changes is unit_testable w/o setting up a git repository. :) I plan to work up a git/svn testing setup soon to make scm.py changes more testable. Eventually I'll work up a local bugzilla setup too.
Adam Barth
Comment 4 2009-08-04 02:21:40 PDT
http://trac.webkit.org/changeset/46753
Note You need to log in before you can comment on or make changes to this bug.