Bug 27969 - bugzilla-tool has too many fatal errors
Summary: bugzilla-tool has too many fatal errors
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2009-08-03 23:30 PDT by Adam Barth
Modified: 2009-08-04 02:21 PDT (History)
1 user (show)

See Also:

Patch v1 (3.92 KB, patch)
2009-08-03 23:35 PDT, Adam Barth
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2009-08-03 23:30:10 PDT
A bunch of the calls to error should raise a ScriptError instead so the commit-queue can continue chugging along.
Comment 1 Adam Barth 2009-08-03 23:35:48 PDT
Created attachment 34038 [details]
Patch v1
Comment 2 Eric Seidel (no email) 2009-08-04 00:25:31 PDT
Comment on attachment 34038 [details]
Patch v1

Looks fine.  We might eventually go back to an error() method which just does the raise for us.  I don't really like logging.py
Comment 3 Eric Seidel (no email) 2009-08-04 00:28:53 PDT
Comment on attachment 34038 [details]
Patch v1

At least one of these changes is unit_testable w/o setting up a git repository. :)  I plan to work up a git/svn testing setup soon to make scm.py changes more testable.

Eventually I'll work up a local bugzilla setup too.
Comment 4 Adam Barth 2009-08-04 02:21:40 PDT