Bug 279611 – [text-underline-position] Paint invalidation sometimes does not properly work

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Tim Nguyen (:ntim)]

Set text-underline-position + text-decoration on this site: https://yitianshijie.vercel.app/2024/08/23/dragon-beard-cantonese-theatre-in-san-francisco

The underline properly repaints after re-selection.

[Radar WebKit Bug Importer]

<rdar://problem/135904727>

[alan]

Created attachment 472542 [details]
Test reduction

This looks to be about invalidating ink overflow area in vertical writing mode.

[alan]

(In reply to zalan from comment #2)
> Created attachment 472542 [details]
> Test reduction
> 
> This looks to be about invalidating ink overflow area in vertical writing
> mode.
when the content box has non-zero offset (e.g. through margin, border, padding)

[alan]

This is the classic flipped block direction repaint bug (not specific to underline)

[alan]

Created attachment 472550 [details]
Patch

[alan]

Created attachment 472551 [details]
Screen recording with the fix applied

[Simon Fraser (smfr)]

Comment on attachment 472550 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=472550&action=review

> COMMIT_MESSAGE:11
> +This is also inline with what we already do for content type of changes.

Potential ambiguous use of "inline".

[alan]

Created attachment 472553 [details]
[fast-cq]Patch

[EWS]

Committed 283666@main (9717bfc4323e): <https://commits.webkit.org/283666@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 472553 [details].

[EWS]

Committed 283286.77@safari-7620-branch (958d1f6cae4e): <https://commits.webkit.org/283286.77@safari-7620-branch>

Reviewed commits have been landed. Closing PR #1828 and removing active labels.