WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
279581
Remove Quirk triggerOptionalStorageAccessQuirk for domains not part of Kinja anymore
https://bugs.webkit.org/show_bug.cgi?id=279581
Summary
Remove Quirk triggerOptionalStorageAccessQuirk for domains not part of Kinja ...
Karl Dubost
Reported
2024-09-11 23:42:43 PDT
On
Bug 213418
/
rdar://64549429
triggerOptionalStorageAccessQuirk was added in addition to isKinjaLoginAvatarElement Quirk ``` static NeverDestroyed<HashSet<RegistrableDomain>> kinjaQuirks = [] { HashSet<RegistrableDomain> set; set.add(RegistrableDomain::uncheckedCreateFromRegistrableDomainString("avclub.com"_s)); set.add(RegistrableDomain::uncheckedCreateFromRegistrableDomainString("deadspin.com"_s)); set.add(RegistrableDomain::uncheckedCreateFromRegistrableDomainString("jalopnik.com"_s)); set.add(RegistrableDomain::uncheckedCreateFromRegistrableDomainString("jezebel.com"_s)); set.add(RegistrableDomain::uncheckedCreateFromRegistrableDomainString("kotaku.com"_s)); set.add(RegistrableDomain::uncheckedCreateFromRegistrableDomainString("lifehacker.com"_s)); set.add(RegistrableDomain::uncheckedCreateFromRegistrableDomainString("theroot.com"_s)); set.add(RegistrableDomain::uncheckedCreateFromRegistrableDomainString("thetakeout.com"_s)); set.add(RegistrableDomain::uncheckedCreateFromRegistrableDomainString("theonion.com"_s)); set.add(RegistrableDomain::uncheckedCreateFromRegistrableDomainString("theinventory.com"_s)); return set; }(); ``` This list is then used later in: if (kinjaQuirks.get().contains(domain) && isKinjaLoginAvatarElement(element)) { … } So it becomes moot when these are not part anymore of Kinja Login system. The list of domains to remove is: * avclub.com * deadspin.com * jezebel.com * lifehacker.com * thetakeout.com * theonion.com
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2024-09-11 23:42:52 PDT
<
rdar://problem/135854408
>
Karl Dubost
Comment 2
2024-09-11 23:53:38 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/33530
EWS
Comment 3
2024-09-12 15:02:24 PDT
Committed
283581@main
(17d716bf8215): <
https://commits.webkit.org/283581@main
> Reviewed commits have been landed. Closing PR #33530 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug