Bug 27958 - WAI-ARIA: Implement 'aria-required' attribute.
Summary: WAI-ARIA: Implement 'aria-required' attribute.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: chris fleizach
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-03 15:53 PDT by chris fleizach
Modified: 2009-08-04 09:15 PDT (History)
0 users

See Also:

Attachments
patch (16.28 KB, patch)
2009-08-03 16:16 PDT, chris fleizach 		jhoneycutt: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description chris fleizach 2009-08-03 15:53:47 PDT 
Implement 'aria-required' attribute.
Comment 1 chris fleizach 2009-08-03 16:16:11 PDT 
Created attachment 34015 [details]
patch
Comment 2 Jon Honeycutt 2009-08-03 22:39:35 PDT 
Comment on attachment 34015 [details]
patch

> Index: WebKitTools/DumpRenderTree/AccessibilityUIElement.cpp
> ===================================================================
> --- WebKitTools/DumpRenderTree/AccessibilityUIElement.cpp	(revision 46735)
> +++ WebKitTools/DumpRenderTree/AccessibilityUIElement.cpp	(working copy)
> @@ -327,6 +327,11 @@ static JSValueRef getIsEnabledCallback(J
>      return JSValueMakeBoolean(context, toAXElement(thisObject)->isEnabled());
>  }
>  
> +static JSValueRef getIsRequiredCallback(JSContextRef context, JSObjectRef thisObject, JSStringRef propertyName, JSValueRef* exception)
> +{
> +    return JSValueMakeBoolean(context, toAXElement(thisObject)->isRequired());
> +}
> +

No need to name the unused params.

> Index: WebKitTools/DumpRenderTree/AccessibilityUIElement.h
> ===================================================================
> --- WebKitTools/DumpRenderTree/AccessibilityUIElement.h	(revision 46735)
> +++ WebKitTools/DumpRenderTree/AccessibilityUIElement.h	(working copy)
> @@ -95,6 +95,7 @@ public:
>      JSStringRef selectedTextRange();
>      bool supportsPressAction();
>      bool isEnabled();
> +    bool isRequired();
>      double clickPointX();
>      double clickPointY();
>  

Looks like this can be const.

r=me
Comment 3 chris fleizach 2009-08-04 09:15:36 PDT 
http://trac.webkit.org/changeset/46768